Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt(alt): tweak some constants to improve scalability #5935

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

carllerche
Copy link
Member

This patch aims to reduce the number of threads that get no-op wakeups.

This patch aims to reduce the number of threads that get no-op wakeups.
@carllerche carllerche added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Aug 15, 2023
@github-actions github-actions bot added the R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR label Aug 15, 2023
@@ -17,6 +17,93 @@ use std::task::{Context, Poll, Waker};

/// Stored in the I/O driver resource slab.
#[derive(Debug)]
// # This struct should be cache padded to avoid false sharing. The cache padding rules are copied
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know it is time to factor this out into a CachePadded abstraction. I pinky promise I'll do it in a follow-up, but I don't want to mix up concerns in this PR.

@carllerche carllerche merged commit 6e42c26 into master Aug 16, 2023
72 checks passed
@carllerche carllerche deleted the rt-alt-tweaks branch August 16, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants