Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Device Broadcast Status #85

Closed
dishapatel010 opened this issue Jul 20, 2023 · 10 comments
Closed

[Feature request] Device Broadcast Status #85

dishapatel010 opened this issue Jul 20, 2023 · 10 comments

Comments

@dishapatel010
Copy link

Allow other apps on devices to see what your listening, so it would be easy to use scrobbler

@toasterofbread
Copy link
Owner

toasterofbread commented Jul 20, 2023

I'm not sure what you mean by this. Is it a specific API you're talking about? If so, please link to some documentation about how it can be implemented.

@dishapatel010
Copy link
Author

I'm not sure what you mean by this. Is it a specific API you're talking about? If so, please link to some documentation about how it can be implemented.

I mean like scrobble takes what we are listening from notification & then does it rest work. So the app should support broadcasting or showing NOTIFICATION what it is playing.

This might be as docs or maybe some other way to show out the notification

@toasterofbread
Copy link
Owner

I'm still not sure what you mean. There's already a notification displaying the currently playing song, but I'm guessing you're not talking about that. The BroadcastReceiver docs you linked don't seem to have anything to do with scrobbling unless there's an API it can be used to communicate with.

Do you mean that SpMp should directly include support for LastFM or other services? (I'm already planning on adding this)
Or do you mean that it should be compatible with apps like the one you listed?

@dishapatel010
Copy link
Author

dishapatel010 commented Jul 20, 2023

I'm still not sure what you mean. There's already a notification displaying the currently playing song, but I'm guessing you're not talking about that. The BroadcastReceiver docs you linked don't seem to have anything to do with scrobbling unless there's an API it can be used to communicate with.

Do you mean that SpMp should directly include support for LastFM or other services? (I'm already planning on adding this) Or do you mean that it should be compatible with apps like the one you listed?

I see that there is notification but it's not showing metadata. So if i want that scrobbler to work with this app it should get captured.
By metadata I mean like else every other app music works

All I mean is app is not showing music metadata for scrobbler app. (Adding in built is different & it's good idea if you are planning it)

@toasterofbread
Copy link
Owner

I see that there is notification but it's not showing metadata. So if I want that scrobbler to work with this app it should get captured.

So the notification isn't showing the song title and artist? It should look roughly like this. The buttons might not appear on some Android versions that I haven't implemented yet, but the title and artist should at least show up.

If that's the case, what version of Android are you using? And could you send a screenshot of what the notification looks like for you?

@dishapatel010
Copy link
Author

I see that there is notification but it's not showing metadata. So if I want that scrobbler to work with this app it should get captured.

So the notification isn't showing the song title and artist? It should look roughly like this. The buttons might not appear on some Android versions that I haven't implemented yet, but the title and artist should at least show up.

If that's the case, what version of Android are you using? And could you send a screenshot of what the notification looks like for you?

Screenshot_20230720-202556~2
Title & artist are shown. I'm on Android 11 Moto e40. (It doesn't get through scrobbler & when i remove app from recents & notification it still plays without any notification)

@toasterofbread
Copy link
Owner

It doesn't get through scrobbler

How can I support that then? I can't add support for something without knowing how the API works. Is this specific to the scrobbler app you mentioned or is it a more general scrobbling system?

@dishapatel010
Copy link
Author

It doesn't get through scrobbler

How can I support that then? I can't add support for something without knowing how the API works. Is this specific to the scrobbler app you mentioned or is it a more general scrobbling system?

Basically it should throw out metadata i like ideal music player would. Ex- YouTube music app or Retro music .
I should suggest look into this retro music code.

If everything is correct scrobbler would work without any doubt
Screenshot_20230721-224045~3

@toasterofbread
Copy link
Owner

I'm sorry, but I really don't have the time to sift through another codebase to figure out how they're implementing the metadata bridge. I had a glance at both apps you linked and I didn't see any obvious documentation or code related to media metadata for scrobbling. Googling about Android media metadata didn't reveal anything either.

I don't use a scrobbler myself, so I don't know exactly how they work and can't test with one easily. If you can find specific documentation about how to add the functionality then I might be able to implement it.

Sorry if this comes across as cold, I'd love to implement this but I just have absolutely no idea how to. I do still plan to add built-in scrobbling at some point though.

@dishapatel010
Copy link
Author

I'm sorry, but I really don't have the time to sift through another codebase to figure out how they're implementing the metadata bridge. I had a glance at both apps you linked and I didn't see any obvious documentation or code related to media metadata for scrobbling. Googling about Android media metadata didn't reveal anything either.

I don't use a scrobbler myself, so I don't know exactly how they work and can't test with one easily. If you can find specific documentation about how to add the functionality then I might be able to implement it.

Sorry if this comes across as cold, I'd love to implement this but I just have absolutely no idea how to. I do still plan to add built-in scrobbling at some point though.

Okay, if i find will mention it. Thanks for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants