Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong timestamps when the song doesn't load #318

Open
4 tasks done
artiekra opened this issue Jun 13, 2024 · 0 comments
Open
4 tasks done

Wrong timestamps when the song doesn't load #318

artiekra opened this issue Jun 13, 2024 · 0 comments
Labels

Comments

@artiekra
Copy link

Checklist

  • I am able to reproduce the bug with the latest debug version (Android, Linux, Windows)
  • I've checked that there is no open or closed issue about this bug.
  • This issue contains only one bug.
  • The title of this issue accurately describes the bug.

Steps to reproduce

(when issue appeared i was logged in)

  1. Make sure the song can't play - for example, turn off the internet (both WiFi/mobile data/etc)
  2. Play a song that was not loaded yet (can just restart the app)
  3. Move (scroll) the timeline a bit, kinda trying to fast forward / rewind a song (try scrolling forward first, and then going back)

Expected behavior

The song is not loaded and can't play (this means its lenght is unknown by spmp). Thus, timeline movement should be either restricted completely, or the timestamp should always show 00:00 (as at the starting position)

Actual behavior

After trying to scroll through the song, weird huge numbers start appearing instead of (hour?) count. Sometimes seems to work fine, but after rewinding, it breaks.

Screenshots / recordings

spmp_issue3.mp4

Logs

Sometimes logcat shows warnings like this (when scrolling through the song):

Touch pointer move a lot. The moving distance of X is:110.641785, limit is:60The moving distance of Y is:3.0168457, limit is:60

Seems like that warning appears every time i scroll the timeline tho, so prob not important?

The following warnings come right after (this ones, i dont get them every time):

2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  java.nio.channels.UnresolvedAddressException
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at sun.nio.ch.Net.checkAddress(Net.java:107)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:663)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at io.ktor.network.sockets.SocketImpl.connect$ktor_network(SourceFile:59)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at kotlin.TuplesKt.connect(SourceFile:101)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at io.ktor.client.engine.cio.ConnectionFactory.connect(SourceFile:245)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at io.ktor.client.engine.cio.Endpoint$connect$2$connect$1.invokeSuspend(SourceFile:41)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at io.ktor.client.engine.cio.Endpoint$connect$2$connect$1.invoke(SourceFile:13)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at okio.Okio.setupTimeout(SourceFile:43)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at okio.Okio.withTimeoutOrNull(SourceFile:82)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at io.ktor.client.engine.cio.Endpoint.connect(SourceFile:356)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at io.ktor.client.engine.cio.Endpoint.makeDedicatedRequest(SourceFile:156)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at io.ktor.client.engine.cio.Endpoint.execute(SourceFile:84)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at io.ktor.client.engine.cio.CIOEngine.execute(SourceFile:182)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at io.ktor.client.engine.HttpClientEngine$executeWithinCallContext$2.invokeSuspend(SourceFile:56)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:8)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at kotlinx.coroutines.DispatchedTask.run(Unknown Source:94)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at androidx.fragment.app.Fragment$4.run(SourceFile:181)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at kotlinx.coroutines.scheduling.TaskImpl.run(Unknown Source:2)
2024-06-13 12:53:43.553 18883-18883 System.err              com.toasterofbread.spmp              W  	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(SourceFile:96)

SpMp version

SpMp non-release build on 837643d and API version 2

SpMp platform

Android

OS version

Android 9

Additional information

Happens with downloaded songs too. I thought those were related issues at first, but im gonna post them as two separate ones.
I think this issue happens with any song, that is NOT LOADED. And that happens when i either: try playing non-donwloaded song without internet; AND sometimes.. when im trying to play downloaded songs. Will try to figure out why those can't play, later..

@artiekra artiekra added the Bug label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant