Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server rework #27

Closed
toasterofbread opened this issue Jan 16, 2023 · 1 comment
Closed

Server rework #27

toasterofbread opened this issue Jan 16, 2023 · 1 comment

Comments

@toasterofbread
Copy link
Owner

toasterofbread commented Jan 16, 2023

The client-server model no longer seems necessary

Pros:

  • Code is easier to maintain/upgrade using Python
  • Server is portable and can be used in future projects (ex. desktop player)
  • Allows large requests to be performed ahead of client request (mainly the home feed)

Cons:

  • Ngrok adds latency to server requests and is a potential bottleneck / failure point
  • Integrated server may be slow (needs testing)

Options:

  • Continue using client-server model, use pre-emptive retrieval to increase speed
  • Keep server code, but use integrated server by default and improve integrated server speed
  • Abandon current server and convert to Kotlin. This could still be used in future projects fairly easily.
@toasterofbread
Copy link
Owner Author

toasterofbread commented Jan 20, 2023

Server code is being moved back to the client.

  • Get video stream URL
  • Get home recommendations feed
  • Load MediaItem data
  • Get song radio
  • Get song related items
  • YouTube search
  • Lyrics search
  • Lyrics retrieval

@toasterofbread toasterofbread added this to the 1.0 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant