Skip to content

Latest commit

 

History

History
61 lines (43 loc) · 2.1 KB

PULL_REQUEST_TEMPLATE.md

File metadata and controls

61 lines (43 loc) · 2.1 KB

Scope & Purpose

(Please describe the changes in this PR for reviewers)

  • 💩 Bugfix
  • 🍕 New feature
  • 🔨 Refactoring
  • 📖 CHANGELOG entry made
  • 💪 The behavior in this PR was manually tested
  • 💻 The behavior change can be verified via automatic tests

Backports:

  • No backports required
  • Backports required for: (Please specify versions)

Related Information

(Please reference tickets / specification etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket number:
  • Design document:

Testing & Verification

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added Regression Tests
    • Added new C++ Unit Tests
    • Added new integration tests (i.e. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)

Additionally:

  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

(Include link to Jenkins run etc)

Documentation

All new Features should be accompanied by corresponding documentation. Bugs and features should furthermore be documented in the changelog so that developers and users have a concise overview.

  • Added a Changelog Entry (referencing the corresponding public or internal issue number)
  • Added entry to Release Notes
  • Added a new section in the Manual
  • Added a new section in the HTTP API
  • Added Swagger examples for the HTTP API
  • Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note

Please note that for legal reasons we require you to sign the Contributor Agreement before we can accept your pull requests.