Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dll is not installed on Windows #32

Open
SpaceIm opened this issue Jun 12, 2021 · 0 comments
Open

dll is not installed on Windows #32

SpaceIm opened this issue Jun 12, 2021 · 0 comments

Comments

@SpaceIm
Copy link

SpaceIm commented Jun 12, 2021

tlx.dll is not installed on Windows when we build shared lib

here is a patch:

--- a/tlx/CMakeLists.txt
+++ b/tlx/CMakeLists.txt
@@ -86,6 +86,7 @@ if(TLX_BUILD_SHARED_LIBS)
   install(TARGETS tlx
     EXPORT tlx-targets
     COMPONENT Libraries
+    RUNTIME DESTINATION ${TLX_INSTALL_BIN_DIR}
     ARCHIVE DESTINATION ${TLX_INSTALL_LIB_DIR}
     LIBRARY DESTINATION ${TLX_INSTALL_LIB_DIR})

It fixes MinGW, but it's not sufficient for Visual Studio because symbols are not exported (CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS is a (dirty) solution, the best would be to properly export public symbols with __declspec(dllexport)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant