Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big endian test failure #24

Open
jamesjer opened this issue Dec 16, 2019 · 1 comment
Open

Big endian test failure #24

jamesjer opened this issue Dec 16, 2019 · 1 comment

Comments

@jamesjer
Copy link

Thank you very much for the versioned tarball. I am attempting to build tlx for Fedora. There is a test failure on our s390x builder; that is a 64-bit big endian architecture:

      Start 33: tlx_string_test
33/40 Test #33: tlx_string_test ............................Child aborted***Exception:   0.30 sec

Running from the command line shows:

DIE-UNEQUAL: tlx::bitdump_le8_type(uint16_t(0x1234)) != "00110100 00010010" : "00010010 00110100" != "00110100 00010010" @ /builddir/build/BUILD/tlx-0.5.20191212/tests/string_test.cpp:139

So the bytes are printed in reverse order. After reading the documentation for bitdump_le8 and bitdump_be8, I'm left uncertain as to what guarantees they make. They seem to be about printing the bits of individual bytes in a particular order. But if you're going to pass multi-byte integers to them, then they have to guarantee something about byte order, too. How do you intend this to work?

@bingmann
Copy link
Member

Thanks for the issue. the le8 name is wrong, I replaced the functions and fixed the test in 5f2f671
Can you rerun the tests, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants