From 0cdf296a48d14c02475ce0aa636c055fe6ea545b Mon Sep 17 00:00:00 2001 From: Paul Chaignon Date: Sat, 5 May 2018 10:47:44 +0200 Subject: [PATCH] tools: Remove unnecessary bpf_probe_read Dereferences of structure members pointing to external addresses are now correctly recognized and replaced by bpf_probe_read calls by the rewriter. --- tools/btrfsslower.py | 4 ++-- tools/ext4slower.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/btrfsslower.py b/tools/btrfsslower.py index a84a5116e0a3..644cb220b4b8 100755 --- a/tools/btrfsslower.py +++ b/tools/btrfsslower.py @@ -224,8 +224,8 @@ // workaround (rewriter should handle file to d_name in one step): struct dentry *de = NULL; struct qstr qs = {}; - bpf_probe_read(&de, sizeof(de), &valp->fp->f_path.dentry); - bpf_probe_read(&qs, sizeof(qs), (void *)&de->d_name); + de = valp->fp->f_path.dentry; + qs = de->d_name; if (qs.len == 0) return 0; bpf_probe_read(&data.file, sizeof(data.file), (void *)qs.name); diff --git a/tools/ext4slower.py b/tools/ext4slower.py index 01c74efc4bd7..756d82624143 100755 --- a/tools/ext4slower.py +++ b/tools/ext4slower.py @@ -219,8 +219,8 @@ // workaround (rewriter should handle file to d_name in one step): struct dentry *de = NULL; struct qstr qs = {}; - bpf_probe_read(&de, sizeof(de), &valp->fp->f_path.dentry); - bpf_probe_read(&qs, sizeof(qs), (void *)&de->d_name); + de = valp->fp->f_path.dentry; + qs = de->d_name; if (qs.len == 0) return 0; bpf_probe_read(&data.file, sizeof(data.file), (void *)qs.name);