-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using redis connection string to cope with node-redis v4 breaking changes #341
Comments
@abhijoshi2k thinking about this more. It seems, if you want to use node-redis v4 for other things and connect-redis for sessions. An acceptable solution for the time being would be to add both v3 and v4 as dependencies and pass the v3 client in to connect-redis. https://stackoverflow.com/a/56495651 We probably could add a note about this in the readme. |
Hello, that can be a valid solution for the time being. Thanks. |
Considering how difficult it is to cope with breaking changes of
node-redis
v4, an option can be added to directly start a separate connection. This option will directly accept the connection URL.This type of option is accepted in one of the rate limit store package named rate-limit-redis (the option is named
redisURL
).Due to this, the above-mentioned package is not affected by the breaking changes.
Similar addition in the
conect-redis
package may resolve the issues.The text was updated successfully, but these errors were encountered: