Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 功能建议:建议新增类似生词本的功能 #33

Open
3 tasks done
hongzzz opened this issue Mar 15, 2023 · 19 comments
Open
3 tasks done

🚀 功能建议:建议新增类似生词本的功能 #33

hongzzz opened this issue Mar 15, 2023 · 19 comments
Labels
enhancement New feature or request PR wanted

Comments

@hongzzz
Copy link

hongzzz commented Mar 15, 2023

请先确认以下事项

  • 已仔细阅读了 README
  • issues 页面搜索过,未发现类似功能建议
  • Easydict 已升级到最新版本

功能描述

在查词界面上加一个收藏按钮,类似有道词典;可以在统一的地方查看生词详情列表;

使用场景(可选)

No response

实现方案(可选)

No response

@hongzzz hongzzz added the enhancement New feature or request label Mar 15, 2023
@github-actions
Copy link

Hello hongzzz, Thank you for your first issue contribution 🎉

@tisfeng
Copy link
Owner

tisfeng commented Mar 16, 2023

可以,感谢反馈,稍后会添加这个功能的。

@tisfeng tisfeng added the feat label Mar 16, 2023
@tisfeng tisfeng removed their assignment Mar 21, 2023
@Nat30
Copy link

Nat30 commented Jul 26, 2023

同需要,感谢

@tisfeng
Copy link
Owner

tisfeng commented Aug 1, 2023

收到,记下了。

@focus7eleven
Copy link

any roadmap on this issue?

@tisfeng
Copy link
Owner

tisfeng commented Dec 11, 2023

暂时没有,要等设置页重构 #227 (comment) 完成后,再来看这个。

@yam-liu
Copy link
Contributor

yam-liu commented Feb 4, 2024

I just found something that can be a temporary solution if we haven't figured out the long-term plan. Eudic itself has a not-so-bad vocabulary system.

https://my.eudic.net/OpenAPI/doc_api_study#-studylistapi-addwords

@tisfeng
Copy link
Owner

tisfeng commented Feb 4, 2024

Currently, the new settings page is almost completed, and some related features can be done.

We can add a favorites button in the top right corner, and add a favorites and history Tab to the settings.

If you are interested in this feature, you can try to push this issue, PR is always welcome 🤗

@yam-liu
Copy link
Contributor

yam-liu commented Feb 5, 2024

@tisfeng Do you support the Eudic's solution or plan to do the app's history? Favorite and history Tabs are two features or the same one? Can you elaborate more?

@tisfeng
Copy link
Owner

tisfeng commented Feb 5, 2024

For now, we can start by only supporting the Favorite/History feature, and Eudic can be put into another issue.

Favorite and History are very similar, we can use a simple way to do it, only record the information of the query word, such as word, queryFromLanguage, timestamp, etc., and don't record the result of the query for the time being.

Each time we perform a query word action, we record the word, which is the History list.
If the user clicks on the New Favorite button in the upper right corner, we add the word to the Favorite list.

@tisfeng
Copy link
Owner

tisfeng commented Feb 5, 2024

I previously added Realm package, you can use it to store favorite words.

Of course, if you have other better solutions, that's fine too.

@ReZeroS
Copy link

ReZeroS commented Mar 31, 2024

记单词能否提供一个配置选项,是否开启 翻译后一定会记录的功能

@tisfeng
Copy link
Owner

tisfeng commented Apr 1, 2024

单词本:手动添加才会记录。
历史记录:每个查询都会被记录。

@yam-liu 你好,请问有在做这个功能吗

@yam-liu
Copy link
Contributor

yam-liu commented Apr 2, 2024

@tisfeng 暂时没有。

@ellya00
Copy link

ellya00 commented May 29, 2024

单词本:手动添加才会记录。 历史记录:每个查询都会被记录。

@yam-liu 你好,请问有在做这个功能吗

这里也有这个需求(就是搜词历史和单词收藏的功能)!!(search 了一下就不开新页面来建议了)

@yam-liu
Copy link
Contributor

yam-liu commented May 29, 2024

@ellya00 没有,不好意思最近开始忙起来了。而且 repo owner 貌似是想自己做一个数据库,我的想法是存到 eudic。这块想法不一样,因为时间不多所以没有深入讨论。

@tisfeng
Copy link
Owner

tisfeng commented May 29, 2024

我也在使用 eudic,对于支持 eudic,将收藏的单词同步到 eudic 这部分没问题。

但考虑到不是所有用户都使用欧路词典,所以 Easydict 本身还是应该实现一个自己的单词记录模块(单词本和历史记录),将单词本同步到 eudic 可以是一个额外功能。

@tisfeng
Copy link
Owner

tisfeng commented May 29, 2024

最近计划使用 SwiftUI 重写查询窗口 #551 ,考虑到 SwiftUI 可能会改动许多数据存储结构,因此单词本功能需要等重写完成后。

@ellya00
Copy link

ellya00 commented May 30, 2024

嗯嗯是的,所以一共是有3个需求,Easydict 自己的单词记录模块里的(1单词本和 2历史记录),和3将单词本导出,应该可以设置特定的格式,导入很多词典吧。不着急更新,就是一些提议~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR wanted
Projects
None yet
Development

No branches or pull requests

7 participants