Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise fails on nightly? #593

Closed
grahamas opened this issue Jan 8, 2021 · 3 comments
Closed

Revise fails on nightly? #593

grahamas opened this issue Jan 8, 2021 · 3 comments

Comments

@grahamas
Copy link

grahamas commented Jan 8, 2021

As of updating to last night's nightly from 2020 Dec 10's build (I skipped all the builds in between), Revise fails (on multiple, seemingly unrelated files; all files that I've tried). I have been updating packages in the meantime, but it's plausible I haven't updated in two weeks, so it could've been a Revise update. I get one of two errors:

┌ Error: Failed to revise /home/graham/git/NeuralModels/src/nonlinearity.jl
│   exception =
│    TypeError: in <:, expected Type, got Vararg
│    Stacktrace:
│     [1] top-level scope
│       @ ~/git/NeuralModels/src/nonlinearity.jl:7
│    Revise evaluation error at /home/graham/git/NeuralModels/src/nonlinearity.jl:7
│    
└ @ Revise ~/.julia/packages/Revise/34vmN/src/packagedef.jl:699

or

┌ Error: Failed to revise /home/graham/.julia/dev/AxisIndices/src/abstractarray.jl
│   exception =
│    UndefVarError: _apply_latest not defined
│    Stacktrace:
│     [1] getproperty(x::Module, f::Symbol)
│       @ Base Base.jl:26
│     [2] top-level scope
│       @ ~/.julia/dev/AxisIndices/src/abstractarray.jl:2
│    Revise evaluation error at /home/graham/.julia/dev/AxisIndices/src/abstractarray.jl:2
│    
└ @ Revise ~/.julia/packages/Revise/34vmN/src/packagedef.jl:699

It's maybe worth noting that both of these errors were in response to my putting an @show x line inside a function, or removing said line (the code loads and runs fine in either case with a REPL restart)

Since all this happens in the background, I'm not really sure how to debug this, but I'll try to create a MWE with a dummy package or something and then see if I can't narrow down what update triggered this (though I won't be able to test julia builds between Dec 10 and Jan 8 since I didn't download them -- but I can at least say whether or not the current Revise version works on the Dec 10 build)

@grahamas grahamas changed the title Revise fails? Revise fails on nightly? Jan 8, 2021
@timholy
Copy link
Owner

timholy commented Jan 8, 2021

It's surely the vararg transition: JuliaLang/julia#38136. You can see from the growing number of references at the end of that PR that there are many packages affected.

I don't have time to fix this right now, but everything should work on Julia 1.6, if you can use that.

@timholy
Copy link
Owner

timholy commented Jan 13, 2021

Revise does not catch this in any of its tests: #595 was the only teeny change needed.

I'm going to need a MWE (or any reproducer) to make progress on this.

@timholy
Copy link
Owner

timholy commented Feb 27, 2021

This has probably been fixed; if not, please file an issue with a reproducer.

@timholy timholy closed this as completed Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants