Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove children with length 0 #9

Closed
timelyportfolio opened this issue Dec 5, 2016 · 2 comments
Closed

remove children with length 0 #9

timelyportfolio opened this issue Dec 5, 2016 · 2 comments

Comments

@timelyportfolio
Copy link
Owner

timelyportfolio commented Dec 5, 2016 •
edited
Loading

Discovered after researching #8, children of length 0 are still being created. Fix this since there is a lot of code out there that does not check for both children && children.length>0 and this could be very problematic.

related to timelyportfolio/SearchTree#2.
@timelyportfolio timelyportfolio mentioned this issue Dec 5, 2016
Closed
@timelyportfolio
Copy link
Owner Author

I think this might actually have been caused by a bug introduced by 5787e03 and fixed in 5787e03, so I will close for now.

Please reopen if you encounter this problem.

@timelyportfolio
Copy link
Owner Author

I actually discovered that this is happening in the test for d3_nest, but then also remembered that this is very tricky to remove, so close again for now. Please let me know if this is causing you trouble and I will happily revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timelyportfolio