Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to tidyr::nest() syntax coming in v1.0.0 #15

Closed
wants to merge 1 commit into from
Closed

Adapt to tidyr::nest() syntax coming in v1.0.0 #15

wants to merge 1 commit into from

Conversation

jennybc
Copy link
Contributor

@jennybc jennybc commented Aug 2, 2019

Closes #13

@jennybc
Copy link
Contributor Author

jennybc commented Aug 2, 2019

Sadly, this code requires dev tidyr, which will go to CRAN soon.

Which plan do you lean towards?

  1. Wait 'til tidyr updates, then update d3r to require that version. We explain that we expect for d3r to be briefly broken in tidyr submission notes.
  2. You extend this fix to check for tidyr version and use different syntax to call nest(), depending on version. You submit d3r soon.
  3. Something else?

@timelyportfolio
Copy link
Owner

@jennybc thanks so much for this. I have a develop branch locally with the fix that I removed temporarily while waiting for tidyr release. I had not thought about checking package version to decide which pattern to use. I think I like this approach best. I'll compare mine versus yours and make sure all works with the newest tidyr.

@timelyportfolio
Copy link
Owner

@jennybc I have tested 029c345 and seems to work with both new and old syntax. If I get the nod, then I will close your very generous pull and move forward with this strategy. I will likely wait until a month passes since last CRAN submit 7/22/2019, update d3, and submit with this change.

Thanks again.

@jennybc
Copy link
Contributor Author

jennybc commented Aug 10, 2019

Definitely proceed with the code you like best, even if that means closing this unmerged.

We used the revdeps -- including this package, which I looked at very early in this effort -- to organize our heads around some new advice for tidyr usage and migration. Anything inspired by or consistent with the new vignette is likely better than this PR.

Your plan sounds good, although there's no specific reason to wait a whole month. The technical minimum is one week.

@timelyportfolio
Copy link
Owner

@jennybc looks like I just need to wait for CRAN maintenance period to end and then submit. I will close this. Appreciate your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d3_nest() fails with dev tidyr
2 participants