Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide option for json in d3_nest #1

Closed
timelyportfolio opened this issue Aug 27, 2016 · 2 comments
Closed

provide option for json in d3_nest #1

timelyportfolio opened this issue Aug 27, 2016 · 2 comments
Labels
enhancement question

Comments

@timelyportfolio
Copy link
Owner

Currently, d3_nest returns a data.frame/tibble. Often, we want the JSON representation of the hierarchy, but unfortunately the default behavior of jsonlite::toJSON does not give us what d3.js expects. Should we provide an argument to return the proper JSON representation or should it be a separate function?
@timelyportfolio
Copy link
Owner Author

elected to provide separate function d3_json

@timelyportfolio
Copy link
Owner Author

reference 5bdf9f3 ; I changed my mind since hierarchy needs to be stripped of outer array and igraph does not. User would need to know too much. I think this is a better default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timelyportfolio