Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to pass temperature in multiple places #88

Closed
jqhoogland opened this issue Jul 17, 2024 · 3 comments
Closed

Need to pass temperature in multiple places #88

jqhoogland opened this issue Jul 17, 2024 · 3 comments
Assignees

Comments

@jqhoogland
Copy link
Contributor

You need to pass a temperature in both the callbacks and the optim_kwargs. We should give a warning if the user only provides one or the other.

@jqhoogland
Copy link
Contributor Author

One of the examples may currently leave out the temperature, thus default to a value and confuse users

@svwingerden
Copy link
Collaborator

I think this fallback behavior is well-documented in both https://timaeus-research.github.io/devinterp/devinterp.optim.html#module-devinterp.optim.sgld and https://timaeus-research.github.io/devinterp/devinterp.slt.html#module-devinterp.slt.llc, so I think a warning is overkill. I can add in a print statement, though.

@wz-ml wz-ml self-assigned this Aug 20, 2024
@wz-ml
Copy link
Contributor

wz-ml commented Aug 20, 2024

Looks like nbeta is now a required parameter in the callbacks that take them: LLCEstimator and MalaAcceptanceRate. I've added print notices in sample and estimate_learning_coeff_with_summary for both directions, just in case this changes. See PR #93 .

@wz-ml wz-ml mentioned this issue Aug 20, 2024
10 tasks
@wz-ml wz-ml closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants