-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the Callout Link to be to the actual bible verse/chapter rather than the API call #84
Comments
I know for the Bible API we'd need another solution. Perhaps we can provide options? Bible Gateway? I was also considering building one to esv.org since they have an API as well, and I already own the study bible with their online account, so that'd be specifically handy for me. :) |
Hi @tim-hub, not sure if you saw the notification, but I made a PR for this change. Be happy to continue contributing if that's helpful. 😄 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @tim-hub, Yes, I think this issue is resolved (I believe). :) |
Sorry, didn't realize I could close the issue. :) |
Is your feature request related to a problem? Please describe.
I was expecting the scripture reference would link to the Bible scripture rather than the JSON request made. Often, with scripture references, it would be nice to be able to read the scriptures around it. So if the link would lead me back to the chapter/verse in an online bible that would be really helpful.
Describe the solution you'd like
I would like the link to the scripture to take me to an online bible where the book and chapter (and potentially verse) is selected.
Looking at the link info, specifically for the Bolls Life API, we can navigate directly to the chapter in it's online view by changing the link information from
[!Bible] [john 10:10 - ESV](https://bolls.life/get-text/ESV/43/10/)
to the following and removing the
get-text
route.[!Bible] [john 10:10 - ESV](https://bolls.life/ESV/43/10/)
Describe alternatives you've considered
As briefly mentioned, potentially instead of a link, we could also display a tooltip with the chapter (potentially with the verse(s) in bold).
Additional context
The text was updated successfully, but these errors were encountered: