Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Callout Link to be to the actual bible verse/chapter rather than the API call #84

Closed
Bill77 opened this issue Mar 6, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@Bill77
Copy link
Contributor

Bill77 commented Mar 6, 2023

Is your feature request related to a problem? Please describe.

I was expecting the scripture reference would link to the Bible scripture rather than the JSON request made. Often, with scripture references, it would be nice to be able to read the scriptures around it. So if the link would lead me back to the chapter/verse in an online bible that would be really helpful.

Potentially an even "cooler" option is a tooltip preview of the verse and the chapter around it (since we already get that from the Bolls Life API).

Describe the solution you'd like

I would like the link to the scripture to take me to an online bible where the book and chapter (and potentially verse) is selected.
Looking at the link info, specifically for the Bolls Life API, we can navigate directly to the chapter in it's online view by changing the link information from

[!Bible] [john 10:10 - ESV](https://bolls.life/get-text/ESV/43/10/)

to the following and removing the get-text route.

[!Bible] [john 10:10 - ESV](https://bolls.life/ESV/43/10/)

Describe alternatives you've considered

As briefly mentioned, potentially instead of a link, we could also display a tooltip with the chapter (potentially with the verse(s) in bold).

Additional context

image

@Bill77 Bill77 added the enhancement New feature or request label Mar 6, 2023
@Bill77
Copy link
Contributor Author

Bill77 commented Mar 6, 2023

I know for the Bible API we'd need another solution. Perhaps we can provide options? Bible Gateway?

I was also considering building one to esv.org since they have an API as well, and I already own the study bible with their online account, so that'd be specifically handy for me. :)

@Bill77
Copy link
Contributor Author

Bill77 commented Mar 8, 2023

Hi @tim-hub, not sure if you saw the notification, but I made a PR for this change. Be happy to continue contributing if that's helpful. 😄

@stale
Copy link

stale bot commented May 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 7, 2023
@stale stale bot closed this as completed May 15, 2023
@tim-hub tim-hub removed the wontfix This will not be worked on label May 15, 2023
@tim-hub tim-hub reopened this May 15, 2023
@stale
Copy link

stale bot commented Jul 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 15, 2023
@tim-hub
Copy link
Owner

tim-hub commented Jul 17, 2023

Hi @tim-hub, not sure if you saw the notification, but I made a PR for this change. Be happy to continue contributing if that's helpful. 😄

HI @Bill77 Do you mean this PR?

This change is in PR #85

@stale stale bot removed the wontfix This will not be worked on label Jul 17, 2023
@Bill77
Copy link
Contributor Author

Bill77 commented Jul 17, 2023

Hi @tim-hub,

Yes, I think this issue is resolved (I believe). :)

@Bill77
Copy link
Contributor Author

Bill77 commented Jul 17, 2023

Sorry, didn't realize I could close the issue. :)

@Bill77 Bill77 closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants