Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish short "two letter" names not working (version 2.3.4) #149

Closed
oscampo opened this issue Oct 12, 2023 · 5 comments
Closed

Spanish short "two letter" names not working (version 2.3.4) #149

oscampo opened this issue Oct 12, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@oscampo
Copy link

oscampo commented Oct 12, 2023

Short "2 letter" names as "Gn", "Ex", "Lv", "Nm"...... "Mt", "Mr", "Lc" , "Jn".... and short names as: "1Cor", "2Cor"
not work in version 2.3.4

Device: DESKTOP
Processor Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz 2.59 GHz
Installed RAM 16.0 GB (15.8 GB usable)
System type 64-bit operating system, x64-based processor
OS: Windows 11 Home Single Language
Version 22H2
Installed on ‎20/‎10/‎2022
OS build 22621.2428
Experience Windows Feature Experience Pack 1000.22674.1000.0

@oscampo oscampo added the bug Something isn't working label Oct 12, 2023
@tim-hub
Copy link
Owner

tim-hub commented Oct 18, 2023

Hi @oscampo

I can reproduce this issue too, checking it now

@oscampo
Copy link
Author

oscampo commented Oct 18, 2023

Hi @tim-hub
The problem is that the code of sp.json was not updated with the last one I commited wich contains the correct short names
Here is the right one:
sp.json

@tim-hub
Copy link
Owner

tim-hub commented Nov 25, 2023

I think besides the issue you mentiond, there is another one here.
the regex trigger requires 3 letters at least.

export const SHORT_REG = /-{2}([123])*\s*[A-z]{3,}\s*\d{1,3}:\d{1,3}(-\d{1,3})*/

@tim-hub
Copy link
Owner

tim-hub commented Nov 25, 2023

this release should gets the fix, feel free to let me know if you still get the same issue.

https://github.com/tim-hub/obsidian-bible-reference/releases/tag/2.3.6

@oscampo
Copy link
Author

oscampo commented Nov 25, 2023

Thanks @tim-hub I just installed this release and I will check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants