Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Spanish Book Names #138

Closed
oscampo opened this issue Sep 14, 2023 · 12 comments
Closed

Please add Spanish Book Names #138

oscampo opened this issue Sep 14, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@oscampo
Copy link

oscampo commented Sep 14, 2023

Thanks in advance!!

@oscampo oscampo added the enhancement New feature or request label Sep 14, 2023
@tim-hub
Copy link
Owner

tim-hub commented Sep 15, 2023

Hi @oscampo

Would you mind helping add the Spanish translation book names?

This is the repo to have different translations,

ref: https://github.com/AntiochTechnology/bible-reference-toolkit/tree/master/packages/bible-book-names-intl/src/data/translations

It is a JSON file in a spercific structure, there are 3 langauges there, if you can help for Spanish, that will be great

feel free to ping me if need help

@tim-hub
Copy link
Owner

tim-hub commented Sep 15, 2023

this is duplicated of #134

@oscampo
Copy link
Author

oscampo commented Sep 15, 2023

Hi @oscampo

Would you mind helping add the Spanish translation book names?

This is the repo to have different translations,

ref: https://github.com/AntiochTechnology/bible-reference-toolkit/tree/master/packages/bible-book-names-intl/src/data/translations

It is a JSON file in a spercific structure, there are 3 langauges there, if you can help for Spanish, that will be great

feel free to ping me if need help
Great! I just created the file "sp.json" following the format you suggest. Here is the file:
spanishBookNames.zip

@oscampo
Copy link
Author

oscampo commented Sep 15, 2023

Hi,
Any problem with the json file ? I saw some reports of errors in the build, but they are related to my file?... sorry I'm checking the report but I can't find which are the errors on my file, because I only see some errors related to another file with book names in english

@tim-hub
Copy link
Owner

tim-hub commented Sep 15, 2023

Hi,
Any problem with the json file ? I saw some reports of errors in the build, but they are related to my file?... sorry I'm checking the report but I can't find which are the errors on my file, because I only see some errors related to another file with book names in english

I should update the markdown file I think, some information missed in the doc. 😅😅

The tests will check the files structure and whether there are duplication.

  • For example, short names can be empty array but cannot be the same as the full name.

  • Books short names have to be unique to each other.

Will check tomorrow and update the readme and let you know the reason why test failed.

@oscampo
Copy link
Author

oscampo commented Sep 15, 2023

Ok... I understand... maybe there is a problem with the name "Job" because is the same for the name of the book end for the short name

@oscampo
Copy link
Author

oscampo commented Sep 18, 2023

@tim-hub I check the json file and updated with unique or blank shortnames

@tim-hub
Copy link
Owner

tim-hub commented Sep 19, 2023

@tim-hub I check the json file and updated with unique or blank shortnames

Thanks

@oscampo
Copy link
Author

oscampo commented Sep 30, 2023

Hi @tim-hub I check you merged sp.json last week, but the obsidian plugin is not updated. Any idea when the version with spanish book names will be available?

@tim-hub
Copy link
Owner

tim-hub commented Oct 1, 2023

Sorry for that, the lib need to be updated to use the Spanish translation

@tim-hub
Copy link
Owner

tim-hub commented Oct 1, 2023

Working on it

@tim-hub
Copy link
Owner

tim-hub commented Oct 1, 2023

@oscampo

This should be fixed in version 2.2.0, Thanks for the patience.

https://github.com/tim-hub/obsidian-bible-reference/releases/tag/2.2.0

@tim-hub tim-hub closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants