-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create proper 429 request limit error response #101
Comments
😢 |
a good idea |
As a sidenote and addition - when I was looking for the cause of this, I had to replace the fetch in this line with |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The Problem
The error is unclear when this plugin hits a request limit.
Reproduction
Type
--John1:1-3
in the editor, and then type a0
at the end and delete it repeatedly. Eventually, the request will return a HTTP 429 status code, indicating it's hitting a rate limit. This is not shown to the user, however, and simply causes the suggester to stop updating.Proposed Solution
Return the error in some way to the user - either by a notification popup or by replacing the content in the suggester with something relevant.
The text was updated successfully, but these errors were encountered: