Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create proper 429 request limit error response #101

Closed
brennenputh opened this issue Jun 30, 2023 · 7 comments
Closed

Create proper 429 request limit error response #101

brennenputh opened this issue Jun 30, 2023 · 7 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@brennenputh
Copy link
Contributor

The Problem

The error is unclear when this plugin hits a request limit.

Reproduction

Type --John1:1-3 in the editor, and then type a 0 at the end and delete it repeatedly. Eventually, the request will return a HTTP 429 status code, indicating it's hitting a rate limit. This is not shown to the user, however, and simply causes the suggester to stop updating.

Proposed Solution

Return the error in some way to the user - either by a notification popup or by replacing the content in the suggester with something relevant.

@brennenputh brennenputh added the bug Something isn't working label Jun 30, 2023
@tim-hub
Copy link
Owner

tim-hub commented Jun 30, 2023

😢

@tim-hub
Copy link
Owner

tim-hub commented Jun 30, 2023

a good idea

@brennenputh
Copy link
Contributor Author

As a sidenote and addition - when I was looking for the cause of this, I had to replace the fetch in this line with requestUrl to get it to spit out a real error instead of a CORS error. Likely a good change to make, but too small for a PR to fix only that.

@stale
Copy link

stale bot commented Sep 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 3, 2023
@tim-hub tim-hub removed the wontfix This will not be worked on label Sep 3, 2023
Copy link

stale bot commented Nov 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 2, 2023
@stale stale bot closed this as completed Nov 9, 2023
@tim-hub tim-hub removed the wontfix This will not be worked on label Nov 21, 2023
@tim-hub tim-hub reopened this Nov 21, 2023
Copy link

stale bot commented Jan 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 20, 2024
@tim-hub tim-hub removed the wontfix This will not be worked on label Jan 21, 2024
Copy link

stale bot commented Mar 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 22, 2024
@stale stale bot closed this as completed Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants