Add loading dialogue while waiting on API (Fixes #100) #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brennenputh I like this idea, it is a good practice to have a waiting UI for it. Do you have a screenshot or GIF/recording of how it will look like? |
tim-hub
reviewed
Jul 14, 2023
|
My bad @tim-hub. Attached is an image showing the container (I had to slow down my network to get to see it lol) |
tim-hub
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discussion
This requires use of Obsidian's internal API, which could change and break the plugin. I think this specific part is unlikely to change, however.
Style improvements welcome - I'm not good at CSS!