Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some additional documentation. #106

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Some additional documentation. #106

merged 2 commits into from
Sep 5, 2018

Conversation

Hoverbear
Copy link
Contributor

Just some small documentation refinements.

@Hoverbear Hoverbear added the Enhancement An improvement to existing code. label Aug 24, 2018
@Hoverbear Hoverbear added this to the 0.4.0 milestone Aug 24, 2018
@Hoverbear Hoverbear self-assigned this Aug 24, 2018
@Hoverbear Hoverbear force-pushed the more-docs branch 2 times, most recently from 5ad2a2f to 13107cf Compare August 24, 2018 20:42
src/raft.rs Outdated
@@ -828,19 +839,22 @@ impl<T: Storage> Raft<T> {
self.set_prs(prs);
}

fn poll(&mut self, id: u64, t: MessageType, v: bool) -> usize {
if v {
/// Set the vote of `id` to `vote`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sets
returns

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my English is so bad. 🤣 I am glad to have an expert to correct me. 🙇‍♀️

@Hoverbear Hoverbear force-pushed the more-docs branch 2 times, most recently from 797f939 to cde9e58 Compare August 27, 2018 16:49
siddontang
siddontang previously approved these changes Aug 28, 2018
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hoverbear Hoverbear merged commit a91eb18 into master Sep 5, 2018
@breezewish breezewish deleted the more-docs branch September 6, 2018 01:47
@Hoverbear Hoverbear added Documentation Documentation related issues and fixes. and removed Enhancement An improvement to existing code. labels Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants