Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon #40

Closed
2024-SANDHYA opened this issue Jul 21, 2022 · 9 comments
Closed

Favicon #40

2024-SANDHYA opened this issue Jul 21, 2022 · 9 comments
Assignees
@Aman-Singh-Kushwaha
Labels
beginner good first issue Good for newcomers SSOC 2022

Comments

@2024-SANDHYA
Copy link

Adding favicon on each and every connected webpages
@Aman-Singh-Kushwaha
Copy link
Contributor

Hey, I can do it

@tier3guy
Copy link
Owner

Go for it

@2024-SANDHYA
Copy link
Author

@tier3guy I opened the issue and according to the rules, the issue should be assigned to me and not any other person commenting on the issue.

@tier3guy
Copy link
Owner

tier3guy commented Jul 24, 2022 •
edited
Loading

@2024-SANDHYA Raising one issue and asking for assignment are two different things,
You raised one issue that's good, that is also one contribution but if you want work on that issue you should ask for assigning that issue.
Hope you got my point. By the way if you want to work on this you can go ahead with this, I will merge both PR's and if some changes will be required, I will assign it back to you.
But for the future references, always ask for assignment.

@Aman-Singh-Kushwaha
Copy link
Contributor

@tier3guy Hey,
Please review favicon work
image

@Aman-Singh-Kushwaha
Copy link
Contributor

this favicon also matches the colour palette and the navbar logo

@Aman-Singh-Kushwaha
Copy link
Contributor

@tier3guy please add SSoC2022 tag on this issue too, so that it can be considered

@tier3guy tier3guy added SSOC 2022 good first issue Good for newcomers labels Jul 30, 2022
@2024-SANDHYA 2024-SANDHYA removed their assignment Jul 30, 2022
@Aman-Singh-Kushwaha
Copy link
Contributor

Hey @tier3guy, I have completed it and raised PR #87 please check it out and review it

@narayan954
Copy link
Collaborator

closing this issue as it has been resolved by @Aman-Singh-Kushwaha

@narayan954 narayan954 mentioned this issue Aug 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aman-Singh-Kushwaha Aman-Singh-Kushwaha

Labels
beginner good first issue Good for newcomers SSOC 2022
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tier3guy @2024-SANDHYA @narayan954 @Aman-Singh-Kushwaha