Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove symlinks in repo #944

Open
opcode81 opened this issue Sep 20, 2023 · 1 comment
Open

Remove symlinks in repo #944

opcode81 opened this issue Sep 20, 2023 · 1 comment
Assignees
@MischaPanch
Labels
enhancement Feature that is not a new algorithm or an algorithm enhancement minor Requires small changes to be fixed on hold Won't be worked on for now, but maybe later
Milestone
Release 2.0.0

Comments

@opcode81
Copy link
Collaborator

opcode81 commented Sep 20, 2023 •
edited
Loading

Two files in the repo are symlinks:

  • examples/vizdoom/network.py -> ../atari/atari_network.py
  • examples/modelbased/psrl.py -> ../../test/modelbased/test_psrl.py

The use of symlinks can cause problems on Windows (git setting core.symlinks must be enabled and Windows Developer Mode must be used).
Unless there is a very good reason to have symlinks, they should be removed.
@Trinkle23897 Trinkle23897 added the enhancement Feature that is not a new algorithm or an algorithm enhancement label Sep 25, 2023
@MischaPanch MischaPanch added minor Requires small changes to be fixed enhancement Feature that is not a new algorithm or an algorithm enhancement and removed enhancement Feature that is not a new algorithm or an algorithm enhancement labels Oct 14, 2023
@MischaPanch MischaPanch added this to the Release 1.0.0 milestone Oct 14, 2023
@opcode81 opcode81 mentioned this issue Oct 26, 2023
Merged
9 tasks
@MischaPanch MischaPanch self-assigned this Nov 10, 2023
@MischaPanch
Copy link
Collaborator

The symlinks are there for executing examples inside tests. I have the feeling that this mechanism should generally be adjusted, after which this issue may become obsolete. I'm putting it on hold for now, as it doesn't seem to be very urgent (given the limited number of devs on windows)

@MischaPanch MischaPanch added the on hold Won't be worked on for now, but maybe later label Nov 13, 2023
@MischaPanch MischaPanch mentioned this issue Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MischaPanch MischaPanch

Labels
enhancement Feature that is not a new algorithm or an algorithm enhancement minor Requires small changes to be fixed on hold Won't be worked on for now, but maybe later
Projects
Overall Tianshou Status
Status: On hold
Milestone
Release 2.0.0
Development

No branches or pull requests
3 participants
@opcode81 @Trinkle23897 @MischaPanch