Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] LSTM for A2C with discrete action space #814

Open
3 of 6 tasks
cbschen opened this issue Feb 27, 2023 · 2 comments
Open
3 of 6 tasks

[question] LSTM for A2C with discrete action space #814

cbschen opened this issue Feb 27, 2023 · 2 comments
Labels
question Further information is requested RNN Temporary label to group all things RNN

Comments

@cbschen
Copy link

cbschen commented Feb 27, 2023

  • I have marked all applicable categories:
    • [] exception-raising bug
    • [] RL algorithm bug
    • documentation request (i.e. "X is missing from the documentation.")
    • new feature request
  • I have visited the source website
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and environment, where applicable:

Hi, I am relatively new to Tianshou and RL and I have been trying to apply LSTM to A2C algorithm with discrete action space. From the documentation, it says to use recurrent policy we need to use RecurrentActorProb, but it seems this is for continuous action space only.

Is there a way to get it work on discrete action space? I tried to use Recurrent + Actor but that does not seem to work.

Also, I saw a lot of opening issues regarding the potential bugs in the RNN functionality in tianshou. Have those been fixed already?

Thank you very much!


This is the error I got when I try to use Recurrent feature extraction net with Actor (for discrete action space):

I apologize if the question seems rudimentary, but I am not quite sure how to get it to work
tianshou question

@nuance1979
Copy link
Collaborator

I have worked on it and have a good idea of how to solve it. However, because of my full-time job, I don't have the time/energy needed to finish it. Would be great if we could get a Google Summer of Code project on this. I'd be glad to be the mentor.

@cbschen
Copy link
Author

cbschen commented Mar 5, 2023

I have worked on it and have a good idea of how to solve it. However, because of my full-time job, I don't have the time/energy needed to finish it. Would be great if we could get a Google Summer of Code project on this. I'd be glad to be the mentor.

Thank you very much for the reply and the proposal and I sincerely appreciate it. I am not sure about my summer schedule yet, but it would be a great opportunity if we could do a project on it. I have sent you a linkedin request as well, if you don't mind to connect.

Again, thank you very much and greatly appreciate it!

@Trinkle23897 Trinkle23897 added the question Further information is requested label Mar 13, 2023
@MischaPanch MischaPanch added the RNN Temporary label to group all things RNN label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested RNN Temporary label to group all things RNN
Projects
None yet
Development

No branches or pull requests

4 participants