Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export libraries #98

Open
nelsonsilva opened this issue Jul 24, 2013 · 5 comments
Open

Re-export libraries #98

nelsonsilva opened this issue Jul 24, 2013 · 5 comments
Labels

Comments

@nelsonsilva
Copy link
Member

I think we should re-export all the libraries to make it easier to use three.dart.
I believe some 3rd party libraries should be re-exported as well (like vector_math) since they are used in three.dart's public API.

@nelsonsilva
Copy link
Member Author

@financecoding @robsilv Do any of you know of any drawbacks on re-exporting libraries ? Does it have any negative impact ?

@adam-singer
Copy link
Member

I'm not aware of anything off the top of my head besides being expected to support those types directly from three.dart via the export functionality. Definitely should make the users pubspec file a bit cleaner.

@nelsonsilva
Copy link
Member Author

M main concern are the imports... Look at https://github.com/threeDart/three.dart/blob/latest/example/webgl_geometry_text/webgl_geometry_text.dart for instance, we've got 6 import statements just for three.dart stuff.

Also, the use of a class for each of the examples has been "bothering" me for a while... This is not java so why do we have our code wrapped in class?

@nelsonsilva
Copy link
Member Author

Hmm... apparently you cannot set a prefix when re-exporting a library...

@adam-singer
Copy link
Member

I've tried todo that in the past. Was not sure what the explicit reason is for not supporting something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants