-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-export libraries #98
Comments
@financecoding @robsilv Do any of you know of any drawbacks on re-exporting libraries ? Does it have any negative impact ? |
I'm not aware of anything off the top of my head besides being expected to support those types directly from three.dart via the export functionality. Definitely should make the users pubspec file a bit cleaner. |
M main concern are the imports... Look at https://github.com/threeDart/three.dart/blob/latest/example/webgl_geometry_text/webgl_geometry_text.dart for instance, we've got 6 import statements just for three.dart stuff. Also, the use of a class for each of the examples has been "bothering" me for a while... This is not java so why do we have our code wrapped in class? |
Hmm... apparently you cannot set a prefix when re-exporting a library... |
I've tried todo that in the past. Was not sure what the explicit reason is for not supporting something like that. |
I think we should re-export all the libraries to make it easier to use three.dart.
I believe some 3rd party libraries should be re-exported as well (like vector_math) since they are used in three.dart's public API.
The text was updated successfully, but these errors were encountered: