Replace mimemagic with marcel gem #2684
Conversation
| require 'logger' | ||
| require 'marcel' |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
There was a problem hiding this comment.
I dismiss the suggestion for consistency with the rest of single quoted requires
|
@mike-burns or any other maintainer, I think this issue should be addressed in order to circumvent the issue with |
|
But mimemagic is MIT licensed. Do we need to do a thing here? |
|
yes, but they circumvented the issue with GPL downloading the problematic GPL file at runtime instead of including it in the source code, which is not an option for environments were the communication with the outside world is restricted. |
|
Those environments will need to install the Since this isn't a license violation for Paperclip, and since Paperclip is deprecated, I'm going to close this. Thank you for bringing it up. |
Replace
mimemagicwithmarcelgem.Resolves #2678