Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix env vars #62

Closed
jolheiser opened this issue Jun 15, 2023 · 3 comments · Fixed by #64
Closed

Prefix env vars #62

jolheiser opened this issue Jun 15, 2023 · 3 comments · Fixed by #64

Comments

@jolheiser
Copy link
Contributor

Consider prefixing the env vars CONFIG (and DEV) with OG_ to avoid collisions.

I'd be happy to submit a small PR if you agree.
@thomiceli
Copy link
Owner

Agreed for DEV, but i would like to deprecate CONFIG since its behavior is weird and might be counter intuitive ?

@jolheiser
Copy link
Contributor Author

I am fine with whichever you prefer.
If this were a CLI tool I might think differently, but a flag is easy enough to set in a service file.

@jolheiser
Copy link
Contributor Author

I just now realized CONFIG actually expects valid YAML? Just skimming I thought it was supposed to be a path to a config file.

If that is the case, I agree with deprecating it. 😅

@jolheiser jolheiser mentioned this issue Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: prefix DEV env var and deprecate CONFIG jolheiser/opengist
2 participants
@thomiceli @jolheiser