Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete rules #93

Closed
pxsalehi opened this issue Jan 10, 2018 · 6 comments
Closed

Cannot delete rules #93

pxsalehi opened this issue Jan 10, 2018 · 6 comments
Assignees
Labels

Comments

@pxsalehi
Copy link

After adding latency, I cannot clear up all rules using tcdel -d DEVICE --all as specified in the doc. I am using v0.17.1. Removing everything (root) using tc works and afterwards tcshow shows no rules.

@thombashi
Copy link
Owner

@pxsalehi

Thank you for your report.
Could you write down the command sequence to reproduce the issue?
I could not reproduce the issue in my environment,

@pxsalehi
Copy link
Author

Start with sudo tcset -d eth0 --delay 100
After this tcshow -d eth0 shows:

{
    "eth0": {
        "outgoing": {
            "protocol=ip": {
                "filter_id": "800::800",
                "delay": "100.0ms",
                "rate": "10G"
            }
        },
        "incoming": {}
    }
}

Issuing sudo tcdel -d eth0 --all results in:

usage: tcdel [-h] [--version] [--tc-command | --tc-script] [--debug | --quiet]
             [--stacktrace] -d DEVICE [--ipv6]
tcdel: error: unrecognized arguments: --all

and tcshow still gives the same output. However, I can remove everything using
sudo tc qdisc del dev eth0 root

I am using tcconfig on a Docker container with Ubuntu 16.04.2 LTS.

@thombashi
Copy link
Owner

Thank you for your information.

Could you re-check your tcconfig version with --version option?
You had described the version is 0.17.1, but tcconfig 0.17.1 have the --all/-a option.

# tcdel --version
tcdel 0.17.1
# tcdel -h
usage: tcdel [-h] [--version] [--tc-command | --tc-script] [--debug | --quiet]
             [--stacktrace] -d DEVICE [-a] [--id FILTER_ID]
             [--direction {outgoing,incoming}] [--network DST_NETWORK]
             [--src-network SRC_NETWORK] [--port DST_PORT]
             [--src-port SRC_PORT] [--ipv6]
...

@pxsalehi
Copy link
Author

ubuntu@broker-1:~$ tcdel --version
tcdel 0.17.1
ubuntu@broker-1:~$ tcdel -h
usage: tcdel [-h] [--version] [--tc-command | --tc-script] [--debug | --quiet]
             [--stacktrace] -d DEVICE [--ipv6]

optional arguments:
  -h, --help            show this help message and exit
  --version             show program's version number and exit
  --tc-command          display tc commands to be executed and exit. these
                        commands are not executed.
  --tc-script           generate a script file that described tc commands
                        which equivalent with execution tcconfig command. the
                        script can be execute without tcconfig package
                        installation.
  --debug               for debug print.
  --quiet               suppress execution log messages.

Debug:
  --stacktrace          print stack trace for debug information. --debug
                        option required to see the debug print.

Traffic Control:
  -d DEVICE, --device DEVICE
                        network device name (e.g. eth0)
  --ipv6                Display IPv6 shaping rules. Defaults to show IPv4
                        shaping rules.

Issue tracker: https://github.com/thombashi/tcconfig/issues

I installed it from here:
https://github.com/thombashi/tcconfig/releases/download/v0.17.1/tcconfig_0.17.1_amd64.deb

@thombashi
Copy link
Owner

thombashi commented Jan 20, 2018

@pxsalehi
Thank you for additional information.

I had created the deb package improperly (especially for the tcdel command).
Please try tcconfig 0.17.2 deb package which fixes the packaging problem.
https://github.com/thombashi/tcconfig/releases/download/v0.17.2/tcconfig_0.17.2_amd64.deb

@thombashi thombashi self-assigned this Jan 20, 2018
@thombashi thombashi added the bug label Jan 20, 2018
@thombashi
Copy link
Owner

@pxsalehi

I'll close the issue.
Feel free to reopen if you still have any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants