Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 100% packet loss or corruption #39

Merged
merged 1 commit into from
Jan 6, 2017

Conversation

pdavies
Copy link
Contributor

@pdavies pdavies commented Jan 6, 2017

I wanted to use tcconfig to simulate loss of connectivity to another machine, by setting

--loss 100 --network <IP>.

This failed, due to a max packet loss rate of 99%. However, tc accepts 100% and appears to work fine, so I think a 100% limit is more useful.

I also changed max corruption rate for the sake of consistency.

😃

@thombashi thombashi merged commit 83fe7b5 into thombashi:master Jan 6, 2017
@thombashi
Copy link
Owner

Thank you for the pull request.

I've merged and update the package to 0.7.0-alpha-2.
You can upgrade with pip install tcconfig --pre --upgrade command.

The reason to limit max packet loss to 99% was that I was worried 100% packet loss setting may cause some problems. However, surely 100% packet loss is one of the use cases.

@pdavies pdavies deleted the full_packet_loss branch January 9, 2017 10:01
@thombashi thombashi mentioned this pull request Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants