Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleSQLite >= 1.5.0 breaks tcconfig #177

Closed
j04n-f opened this issue Nov 28, 2023 · 2 comments
Closed

SimpleSQLite >= 1.5.0 breaks tcconfig #177

j04n-f opened this issue Nov 28, 2023 · 2 comments
Labels

Comments

@j04n-f
Copy link

j04n-f commented Nov 28, 2023

Describe the bug

SimpleSQLite version is not pinned (floating version):

SimpleSQLite>=1.1.1,<2

New versions of the package breaks tcconfig commands. Forcing SimpleSQLite v1.4.0 installation solves the problem.

Expected behavior

tcshow eth0 command should display the network constrains applied to eth0.

To Reproduce

Steps to reproduce the behavior:

  1. pip install tcconfig
  2. pip install SimpleSQLite==1.5.1
  3. tcshow eth0

Additional context

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.6/x64/bin/tcshow", line 5, in <module>
    from tcconfig.tcshow import main
  File "/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/tcconfig/tcshow.py", line 24, in <module>
    from .parser.shaping_rule import TcShapingRuleParser
  File "/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/tcconfig/parser/shaping_rule.py", line 21, in <module>
    from ._filter import TcFilterParser
  File "/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/tcconfig/parser/_filter.py", line 15, in <module>
    from ._model import Filter
  File "/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/tcconfig/parser/_model.py", line 6, in <module>
    class Filter(Model):
  File "/opt/hostedtoolcache/Python/3.11.6/x64/lib/python3.11/site-packages/tcconfig/parser/_model.py", line 7, in Filter
    device = Text(attr_name=Tc.Param.DEVICE, not_null=True)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Column.__init__() got an unexpected keyword argument 'attr_name'
@merinsTDL
Copy link

Reproduced the same issue. Works if pip depencancy gets reverted to 1.4.0.
Even tcset -h fails with this static error.

@thombashi thombashi added bug and removed needs-triage labels Dec 1, 2023
@thombashi
Copy link
Owner

@joan-mido-qa @merinsTDL
Thank you for your report.
I have released SimpleSQLite v1.5.2 that restores backward compatibility as a workaround.

@j04n-f j04n-f closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants