-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with busybox #176
Labels
Comments
Thank you for your report. To check the capability permission, it is necessary to obtain the full path of the command entity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Fetching command paths like for the
ip
command doesn't work on systems usingbusybox
.OpenWRT uses
busybox
which provides commands likeip
for embedded Linux systems.Expected behavior
Running
tcset
to create incoming rate shaping rules works even if theip
command is provided throughbusybox
.To Reproduce
Steps to reproduce the behavior:
tcset eth0 --direction incoming --rate 1Mbps
/path/to/busybox link add dev ifbXXXX type ifb
and fails with errorsEnvironments
Please execute the following command and past the output:
Removed, reason for this issue is already known and noted below.
Complete the following information:
pip
/deb package
Additional context
Add any other context (logs, error output, etc.) about the problem here.
The
ip
command path is not found on OpenWRT becausetcconfig
uses pythonsubprocrunner.Which
with following symlinks enabled.See
tcconfig/tcconfig/_common.py
Line 45 in e14f9fb
It is used since 179fcaf.
The command
ip
is symlinked withbusybox
in OpenWRT.When the symlink option of that command is set to
False
in a manual test theip
command path (/path/to/ip
) can be fetched successfully.Was there a specific reason to enable symlinks here?
A workaround would be to generate a
tc
script throughtcconfig
, modify it and use that.It would be nice if it works with
busybox
, too.If yes, then the symlink option is in question.
The text was updated successfully, but these errors were encountered: