Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple excluded networks #155

Open
koorgoo opened this issue Nov 12, 2020 · 1 comment · May be fixed by #156
Open

Support multiple excluded networks #155

koorgoo opened this issue Nov 12, 2020 · 1 comment · May be fixed by #156
Labels
bug

Comments

@koorgoo
Copy link

koorgoo commented Nov 12, 2020 •
edited
Loading

Hi,

I am using tcconfig to test software, but --exclude-dst-network and --exclude-src-network with single values is not enough in my case - there are multiple subnets I need to allow traffic to/from.

I suggest supporting multiple parameters with ArgumentParser.add_argument('--argument', nargs='*', ...).

tcset eth0 --direction outgoing --exclude-dst-network 1.2.3.0/24 1.2.0.0/16 --delay 100ms
tcset eth0 --direction incoming --exclude-src-network 1.2.3.0/24 1.2.0.0/16 --delay 100ms
@koorgoo koorgoo linked a pull request Nov 13, 2020 that will close this issue
Open
@koorgoo koorgoo changed the title Support multiple networks in parameters Support multiple excluded networks Nov 13, 2020
@thombashi
Copy link
Owner

Hi, thank you for your feedback.

Ideally, that would be achieved by multiple tcset executions like:

tcset eth0 --direction outgoing --exclude-dst-network 1.2.3.0/24 --delay 100ms
tcset eth0 --direction outgoing --exclude-dst-network 1.2.0.0/16 --delay 100ms --add
tcset eth0 --direction incoming --exclude-src-network 1.2.3.0/24 --delay 100ms
tcset eth0 --direction incoming --exclude-src-network 1.2.0.0/16 --delay 100ms --add

However, execution with --add option somewhat failed. This is probably a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multiple excluded networks
2 participants
@koorgoo @thombashi