Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/upgrade electron #757

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Chore/upgrade electron #757

merged 9 commits into from
Apr 2, 2024

Conversation

bj00rn
Copy link
Collaborator

@bj00rn bj00rn commented Mar 10, 2024

  • upgrade electron* packages
  • upgrade dependencies to resolve build errors
    • require node 19 18 as required by electron 29
    • ts-node
  • fix some minor type errors
  • moved the sparkplug protocol to a js import since it seems that the file is not included in packaging

@bj00rn
Copy link
Collaborator Author

bj00rn commented Mar 10, 2024

@thomasnordquist can you please have a look at this. Builds locally on my machine. I have not tested packaging.

…ging

maybe there is a better way to resolve this..
@bj00rn bj00rn merged commit 0c6d777 into master Apr 2, 2024
3 checks passed
@bj00rn bj00rn deleted the chore/upgrade-electron branch April 2, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant