Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings propagation in tree #81

Closed
kloggy opened this issue Mar 21, 2019 · 6 comments
Closed

Fix settings propagation in tree #81

kloggy opened this issue Mar 21, 2019 · 6 comments
Labels
bug Something isn't working Next Release

Comments

@kloggy
Copy link

kloggy commented Mar 21, 2019

I see that there was an issue that appeared to address (490678d, closed on 13 Jan) but I still see topics in a 'random' ordered list.

Thanks.

image

image

@thomasnordquist thomasnordquist changed the title Can you i nclude a menu option to sort topics? Fix topic order propagation Mar 21, 2019
@thomasnordquist thomasnordquist added the bug Something isn't working label Mar 21, 2019
@thomasnordquist
Copy link
Owner

Thanks for reporting 👍.
The problem here is that the new "topic order" is not immediately propagated to nested topics, only when a child topic receives an update.

Quick Fix:
Collapsing and expanding the "root" node (or simply reconnecting) will resolve this issue.

I'll keep you posted when it is fixed and when the fix has been released, there are also a few other things I'd like to put in the next release.

@kloggy
Copy link
Author

kloggy commented Mar 21, 2019

That's great thanks. I was using MQTT.fx until I found this and I far prefer this!

@thomasnordquist
Copy link
Owner

Glad to hear it =)

@kloggy
Copy link
Author

kloggy commented Mar 21, 2019

Although....
From this to this:
image

To this:
image

doesn't seem to re-sort. (Just so you know)

@thomasnordquist
Copy link
Owner

thomasnordquist commented Mar 21, 2019

Note to myself: I also noticed this behavior for the "Quick Preview" option.
I should probably start using immutables (immutablejs) to guarantee the propagation of settings/values in the tree.

Directly connecting the nodes to the store is not possible since it would have a huge performance impact on every store update, even if store changes are unrelated to the topic. (10k nodes ~150ms, just propagating store updates)

@thomasnordquist thomasnordquist changed the title Fix topic order propagation Fix settings propagation in tree Mar 21, 2019
@thomasnordquist
Copy link
Owner

Fixed with 436b569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Next Release
Projects
None yet
Development

No branches or pull requests

2 participants