Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-test: Expand topic does not handle non unique topics #796

Open
bj00rn opened this issue May 24, 2024 · 0 comments
Open

ui-test: Expand topic does not handle non unique topics #796

bj00rn opened this issue May 24, 2024 · 0 comments

Comments

@bj00rn
Copy link
Collaborator

bj00rn commented May 24, 2024

expandTopic logic is broken, it does not work for nodes that share the same name on different levels.

I had to change the logic since playwright is prevented from expanding hidden nodes by accessibility. I.e to expand lamp of topic livingroom/lamps/lamp, livingroom->lamps->lamp must be expanded in sequence.

the current logic will not work when you have multiple topics with lamp in the path

livingroom/lamps/lamp
kitchen/lamps/lamp

const selectors = topics.map(v => `span[data-test-topic='${v}']`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant