Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-Name-Indication for MQTT connections #130

Closed
mworrell opened this issue Jun 20, 2019 · 7 comments
Closed

Server-Name-Indication for MQTT connections #130

mworrell opened this issue Jun 20, 2019 · 7 comments

Comments

@mworrell
Copy link

We are currently adding MQTT listeners to https://github.com/zotonic/zotonic and using MQTT-Explorer for manual testing and inspection.

Zotonic uses vhosts with a MQTT broker per site.

In the ws connection Server-Name-Indication is used.
Though it seems that in the mqtt connection type Server-Name-Indication is not used.

Could Server-Name-Indication be added to the mqtt connection type?

Thanks for this great utility.

@thomasnordquist
Copy link
Owner

thomasnordquist commented Jun 20, 2019

I'm glad you like it 😄

Added support with 2614549 (assuming the Node TLS documentation is correct)

I also prepared a pre-release for you to test the changes:
Edit: https://github.com/thomasnordquist/MQTT-Explorer/releases/tag/v0.0.0-0.3.1-alpha-sni

Would be awesome if you tell me if it works!

@thomasnordquist
Copy link
Owner

In the current implementation, it appears the port number is part of the hostname.
Just started working on client certificate support when I noticed.

@thomasnordquist
Copy link
Owner

@mworrell
Copy link
Author

You are fast! I checked the release candidate and it works like a charm.

09:38:46.918 [info] DEBUG: z_ssl_certs:63  {<0.31085.2>,"t.lamma"}

Hostname comes through, exactly how it is expected in the SNI routines.

@thomasnordquist
Copy link
Owner

Glad to hear it, will be part of an official release soon.

@thomasnordquist
Copy link
Owner

Released with v0.3.5.

@mworrell
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants