Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: line 8 for history #37

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: line 8 for history #37

merged 1 commit into from
Dec 5, 2023

Conversation

thomas-mauran
Copy link
Owner

fix bug on line 8 behing 0 in the historic

Description

The bug was pretty simple and displayed 0 instead of 8 when moving from or to the first row (going from top to bottom)

Fixes #36

How Has This Been Tested?

  • convert_position_into_notation_1
  • convert_position_into_notation_2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@thomas-mauran
fix: line 8 bug historic
2e86412 
Signed-off-by: Thomas Mauran <[email protected]>
@thomas-mauran thomas-mauran self-assigned this Dec 5, 2023
@thomas-mauran thomas-mauran added the bug Something isn't working label Dec 5, 2023
@thomas-mauran thomas-mauran merged commit 592de11 into main Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomas-mauran thomas-mauran

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(historic): line 8 is translated to 0
1 participant
@thomas-mauran