Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove explicitly set background on board blocks #16

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix: remove explicitly set background on board blocks #16

merged 2 commits into from
Dec 1, 2023

Conversation

Kuruyia
Copy link
Contributor

@Kuruyia Kuruyia commented Dec 1, 2023

Remove explicitly set background on board blocks

Description

This removes the explicitly-set background on the board blocks to use the default background color of the terminal.

Fixes #15

How Has This Been Tested?

See before:
demo

After:
demo

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@thomas-mauran thomas-mauran added the enhancement New feature or request label Dec 1, 2023
@thomas-mauran thomas-mauran merged commit e0a2803 into thomas-mauran:main Dec 1, 2023
6 of 7 checks passed
@Kuruyia Kuruyia deleted the fix/board-borders branch December 1, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(board): make border transparent
2 participants