Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Options Config with CLI Parameters #112

Open
cdsupina opened this issue Sep 20, 2023 · 0 comments
Open

Replace Options Config with CLI Parameters #112

cdsupina opened this issue Sep 20, 2023 · 0 comments
Labels

Comments

@cdsupina
Copy link
Contributor

          I think we should delete this. CLI parameters are a more standard way to do this. `thetawave --resolution 1920x1080 --fullscreen` and those can be used for launch options in steam. I dont think we want others to change this via ron (99.99% of people dont know what RON is, but almost all programmers can do `thetawave --help` and set CLI params). 

pub struct GameInitCLIOptions {

Atleast outside of the browser, we can save user settings in sqlite. Keeping a couple of preconfigured ones as ron is...fine for now (if they can be toml and are simple enough, I think toml is better and more portable/standard; i dont particularly value serde's data model enough to have a strong preference for ron).

Originally posted by @varoonp123 in #108 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant