Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required: extend_formula_ncem #162

Open
merelkuijs opened this issue Mar 21, 2024 · 0 comments
Open

Update required: extend_formula_ncem #162

merelkuijs opened this issue Mar 21, 2024 · 0 comments

Comments

@merelkuijs
Copy link
Member

Hi Anna,

Currently, the extend_formula_ncem function (referenced below) computes a list of coef_couplings:

coef_couplings = [f"{PREFIX_INDEX}{x}:{PREFIX_NEIGHBOR}{y}" for y in cell_types for x in cell_types]

For my cell types, this list looks like:

['index_AcinarCells:neighbor_AcinarCells', 'index_AcinarCells:neighbor_B', 'index_AcinarCells:neighbor_Basal', ...]

However, the get_dmats_from_deconvoluted generates a different list of coefficients. When I inspect dmats[x].design_info.column_names, I instead see

['index_AcinarCells[False]:neighbor_AcinarCells', 'index_AcinarCells[True]:neighbor_AcinarCells', 'index_AcinarCells[False]:neighbor_B', 'index_AcinarCells[True]:neighbor_B', ...]

Note the addition of [False] and [True]. The fact that these lists are different leads to problems when we run test_deconvoluted.

I think this issue can be fixed by updating the extend_formula_ncem function. I'll take a look at it and let you know when I have a solution.

coef_couplings = [f"{PREFIX_INDEX}{x}:{PREFIX_NEIGHBOR}{y}" for y in cell_types for x in cell_types]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant