Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"There is no difference between these revisions" - entry for certain API saves and certain field types. #47

Open
adrianbj opened this issue Aug 9, 2022 · 0 comments

Comments

@adrianbj
Copy link

adrianbj commented Aug 9, 2022

Hi @teppokoivula

I am seeing new entries with that text for certain field types. For some field types it only happens if I use setAndSave(), but for others, it happens even with a regular save().

The save is happening via an AJAX call and I don't do any checking on old (already in the DB) vs new (values submitted via the form) so I am always setting the value of every field as part of the save process. Not sure if that is relevant or not though.

For text and date fields it's only an issue if I do setAndSave(), but for page reference fields, it happens regardless of how I save. Another problematic field type is my phone field which also gets a revision entry regardless of how I save.

I wonder if perhaps the easiest way to fix this would be to have an option to not record a revision if there is no change?

OT, but back to the phone field - it only supports the main number subfield - do you think it would be possible to support the country subfield as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant