-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issue in /data.py (by P3) #28
Comments
Hello, I'm looking forward to your reply~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! I've found a performance issue in /data.py:
ds.batch(batch_size)
(here) should be called beforeds.map(_map_fn, num_parallel_calls=4)
(here), which could make your program more efficient.Here is the tensorflow document to support it.
Besides, you need to check the function
_map_fn
called inds.map(_map_fn, num_parallel_calls=4)
whether to be affected or not to make the changed code work properly. For example, if_map_fn
needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
The text was updated successfully, but these errors were encountered: