{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":91379993,"defaultBranch":"master","name":"tensorboard","ownerLogin":"tensorflow","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-05-15T20:08:07.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/15658638?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718819691.0","currentOid":""},"activityList":{"items":[{"before":"c19a63a081508742487bc95713622d3f0ecaeb1e","after":"b163c5df852f08468013fb292bff854e5f49add0","ref":"refs/heads/master","pushedAt":"2024-06-21T14:05:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"JamesHollyer","name":"James","path":"/JamesHollyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8672809?s=80&v=4"},"commit":{"message":"Update usage of numpy to reflect numpy 2.0 changes (#6871)\n\n## Motivation for features / changes\r\nNightlies are failing due to new numpy release(one example:\r\nhttps://github.com/tensorflow/tensorboard/actions/runs/9546526095/job/26309613783)\r\n\r\n## Technical description of changes\r\nThe new numpy replaced np.string_ with np.bytes_ and np.unicode_ with\r\nnp.str_\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\nI ran tests that were failing and they passed.\r\n\r\n## Alternate designs / implementations considered (or N/A)\r\nLocking numpy version < 2 was considered. However, this will eventually\r\nget us very out of date and should be avoided.\r\n\r\n---------\r\n\r\nCo-authored-by: James Hollyer ","shortMessageHtmlLink":"Update usage of numpy to reflect numpy 2.0 changes (#6871)"}},{"before":null,"after":"aa9a02f2ad4a6aabbeeaecea8eac4464ee97e50d","ref":"refs/heads/dependabot/npm_and_yarn/socket.io-4.7.5","pushedAt":"2024-06-19T17:54:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump socket.io from 4.5.3 to 4.7.5\n\nBumps [socket.io](https://github.com/socketio/socket.io) from 4.5.3 to 4.7.5.\n- [Release notes](https://github.com/socketio/socket.io/releases)\n- [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/socketio/socket.io/compare/4.5.3...4.7.5)\n\n---\nupdated-dependencies:\n- dependency-name: socket.io\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump socket.io from 4.5.3 to 4.7.5"}},{"before":"7909f5db639f1c9ac0b3ad8f0ce49a8f4435ce35","after":null,"ref":"refs/heads/dependabot/npm_and_yarn/braces-3.0.3","pushedAt":"2024-06-17T21:42:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"yatbear","name":"Yating","path":"/yatbear","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15273931?s=80&v=4"}},{"before":"67dcad9af7d4a3481ce1de6fda66840072f66b5e","after":"c19a63a081508742487bc95713622d3f0ecaeb1e","ref":"refs/heads/master","pushedAt":"2024-06-17T21:42:22.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"yatbear","name":"Yating","path":"/yatbear","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15273931?s=80&v=4"},"commit":{"message":"Bump braces from 3.0.2 to 3.0.3 (#6868)\n\nBumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.\r\n
\r\nCommits\r\n
    \r\n
  • 74b2db2\r\n3.0.3
    • \r\n
  • 88f1429\r\nupdate eslint. lint, fix unit tests.
    • \r\n
  • 415d660\r\nSnyk js braces 6838727 (#40)
    • \r\n
  • 190510f\r\nfix tests, skip 1 test in test/braces.expand
    • \r\n
  • 716eb9f\r\nreadme bump
    • \r\n
  • a5851e5\r\nMerge pull request #37\r\nfrom coderaiser/fix/vulnerability
    • \r\n
  • 2092bd1\r\nfeature: braces: add maxSymbols (https://github.com/micromatch/braces/issues/...
    • \r\n
  • 9f5b4cf\r\nfix: vulnerability (https://security.snyk.io/vuln/SNYK-JS-BRACES-6838727)
    • \r\n
  • 98414f9\r\nremove funding file
    • \r\n
  • 665ab5d\r\nupdate keepEscaping doc (#27)
    • \r\n
  • Additional commits viewable in compare\r\nview
    • \r\n
\r\n
\r\n
\r\n\r\n\r\n[![Dependabot compatibility\r\nscore](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=braces&package-manager=npm_and_yarn&previous-version=3.0.2&new-version=3.0.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)\r\n\r\nDependabot will resolve any conflicts with this PR as long as you don't\r\nalter it yourself. You can also trigger a rebase manually by commenting\r\n`@dependabot rebase`.\r\n\r\n[//]: # (dependabot-automerge-start)\r\n[//]: # (dependabot-automerge-end)\r\n\r\n---\r\n\r\n
\r\nDependabot commands and options\r\n
\r\n\r\nSigned-off-by: dependabot[bot] \r\nCo-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>","shortMessageHtmlLink":"Bump braces from 3.0.2 to 3.0.3 (#6868)"}},{"before":null,"after":"7909f5db639f1c9ac0b3ad8f0ce49a8f4435ce35","ref":"refs/heads/dependabot/npm_and_yarn/braces-3.0.3","pushedAt":"2024-06-16T09:58:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump braces from 3.0.2 to 3.0.3\n\nBumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.\n- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)\n- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3)\n\n---\nupdated-dependencies:\n- dependency-name: braces\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump braces from 3.0.2 to 3.0.3"}},{"before":"9251adeaa6f800a39b84892c4c5d6359cab62418","after":"67dcad9af7d4a3481ce1de6fda66840072f66b5e","ref":"refs/heads/master","pushedAt":"2024-06-11T02:04:56.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"arcra","name":"Adrian RC","path":"/arcra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1861094?s=80&v=4"},"commit":{"message":"Release notes for TensorBoard 2.17.0\n\n(cherry picked from commit 0d53d319c2b0b5c3ea4f074c47b8d6570b43ad74)","shortMessageHtmlLink":"Release notes for TensorBoard 2.17.0"}},{"before":"f1591d333568df27e7759f563dceb5a2f374cef3","after":"9251adeaa6f800a39b84892c4c5d6359cab62418","ref":"refs/heads/master","pushedAt":"2024-06-10T21:44:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"arcra","name":"Adrian RC","path":"/arcra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1861094?s=80&v=4"},"commit":{"message":"Update tests to be compatible with recent keras update. (#6866)\n\n## Motivation for features / changes\r\nA recent change in Keras broke these tests. I believe it's related to\r\nkeras-team/keras#19805, which caused a name change in the names of the\r\nnodes in the graph, but not too sure.\r\n\r\n## Technical description of changes\r\nUpdates the affected test, but leaves it commented out, because when\r\nthis code is imported into the internal repository on our side, before\r\nthe keras update does, our project would break, as the keras change\r\nwould not be synced internally yet.\r\nOnce this is sycned to our internal repo, and keras is able to sync\r\ntheirs (without breaking us), we can enable the test and it should work\r\nfine.\r\n\r\n## Screenshots of UI changes (or N/A)\r\nN/A\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\nRan tests with keras-nightly before and after the change, and they pass.\r\nThen commented out the test for the reason noted above.\r\n\r\n## Alternate designs / implementations considered (or N/A)\r\nN/A","shortMessageHtmlLink":"Update tests to be compatible with recent keras update. (#6866)"}},{"before":"f1591d333568df27e7759f563dceb5a2f374cef3","after":"9408e08f18e0eb3a7556b42b907674f8af775e0f","ref":"refs/heads/2.17","pushedAt":"2024-06-07T19:48:32.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"arcra","name":"Adrian RC","path":"/arcra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1861094?s=80&v=4"},"commit":{"message":"TensorBoard 2.17.0","shortMessageHtmlLink":"TensorBoard 2.17.0"}},{"before":null,"after":"f1591d333568df27e7759f563dceb5a2f374cef3","ref":"refs/heads/2.17","pushedAt":"2024-06-05T22:05:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"arcra","name":"Adrian RC","path":"/arcra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1861094?s=80&v=4"},"commit":{"message":"Dedupe unknown query params from feature flag query params. (#6824)\n\nSince #6784 we have seen the unusual behavior where query params for\r\nfeature flags will be duplicated on the command line.\r\n\r\nFor example, if we load `localhost:6006/?showFlags=` it will be\r\nrewritten as `localhost:6006/?showFlags=&showFlags=`.\r\n\r\nThis change fixes this by deduplicating \"unknown\" flags with known\r\nfeature flag query params.","shortMessageHtmlLink":"Dedupe unknown query params from feature flag query params. (#6824)"}},{"before":"c3fd2b5e503905f07a46c6b95e12ebd81c48f3c7","after":"f1591d333568df27e7759f563dceb5a2f374cef3","ref":"refs/heads/master","pushedAt":"2024-06-05T15:36:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bmd3k","name":"Brian Dubois","path":"/bmd3k","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17152369?s=80&v=4"},"commit":{"message":"Dedupe unknown query params from feature flag query params. (#6824)\n\nSince #6784 we have seen the unusual behavior where query params for\r\nfeature flags will be duplicated on the command line.\r\n\r\nFor example, if we load `localhost:6006/?showFlags=` it will be\r\nrewritten as `localhost:6006/?showFlags=&showFlags=`.\r\n\r\nThis change fixes this by deduplicating \"unknown\" flags with known\r\nfeature flag query params.","shortMessageHtmlLink":"Dedupe unknown query params from feature flag query params. (#6824)"}},{"before":"ae7d0b9250f5986dd0f0c238fcaf3c8d7f4312ca","after":"c3fd2b5e503905f07a46c6b95e12ebd81c48f3c7","ref":"refs/heads/master","pushedAt":"2024-06-04T17:43:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AnuarTB","name":"Anuar Talipov","path":"/AnuarTB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5575949?s=80&v=4"},"commit":{"message":"Fix the issue with coloring when trying to add more experiments. (#6861)\n\nThere was a problem when user tried to 1) enable coloring by experiment\r\nname, 2) trying to add more experiments. It stemmed from not\r\nimplementing the serialization and deserialization of REGEX_BY_EXP in\r\nthe query pararms of the route. To followup the #6846 and #6847 I have\r\nadded the 'regex_exp:' as a query parameter for coloring by experiment\r\nname.\r\n\r\n## Motivation for features / changes\r\n\r\nTo fix the issue with the new feature. \r\n\r\n## Technical description of changes\r\n\r\nAdded `regex_exp:` query param for serialization and deserialization of\r\n`REGEX_BY_EXP` GroupBy. It ensures that whenever user share the URL the\r\nfilter will remain in place.\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\n\r\n1) Enable the coloring by experiment name.\r\n2) Try to add more experiments via pressing `Add more experiments` in\r\nthe top panel.\r\n\r\n## Alternate designs / implementations considered (or N/A)","shortMessageHtmlLink":"Fix the issue with coloring when trying to add more experiments. (#6861)"}},{"before":"cbeecb7df4d0855527ad64c7decd3e856070d266","after":"ae7d0b9250f5986dd0f0c238fcaf3c8d7f4312ca","ref":"refs/heads/master","pushedAt":"2024-05-21T23:34:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"arcra","name":"Adrian RC","path":"/arcra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1861094?s=80&v=4"},"commit":{"message":"Fixes regression for issue #5548: Avoid attempting to convert dtypes from \"mixed precision\" policy types. (#6859)\n\nFollowing-up on PR #6857, which seems to have introduced a regression\r\nfor issue #5548.\r\n\r\nThis change just gracefully degrades the functionality to avoid crashing\r\non an error (as it was before the recent change in #6857), but it might\r\nnot be a proper fix for the scenario described in that issue.","shortMessageHtmlLink":"Fixes regression for issue #5548: Avoid attempting to convert dtypes …"}},{"before":"5f8b0199272335f53ab61a1a0ba4341c5a141b43","after":"cbeecb7df4d0855527ad64c7decd3e856070d266","ref":"refs/heads/master","pushedAt":"2024-05-21T16:45:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"arcra","name":"Adrian RC","path":"/arcra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1861094?s=80&v=4"},"commit":{"message":"Fix keras dtype importing and unpin for CI (#6857)\n\nKeras' output format was slightly changed in\r\nhttps://github.com/keras-team/keras/pull/19711; for non-input layers\r\ndtypes will now be exported as a config map instead of just a string.\r\nThis fixes test breakages when using ToT keras.\r\n\r\nAlternative to #6855","shortMessageHtmlLink":"Fix keras dtype importing and unpin for CI (#6857)"}},{"before":"7df7ad9855f0f7b4bd8ac90350580bc482c9d062","after":"5f8b0199272335f53ab61a1a0ba4341c5a141b43","ref":"refs/heads/master","pushedAt":"2024-05-21T01:20:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AnuarTB","name":"Anuar Talipov","path":"/AnuarTB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5575949?s=80&v=4"},"commit":{"message":"Adds import that was used via a transitive dependency. (#6856)\n\nThis was missing when #6847 was merged, but it's causing some build\r\nerrors in internal repo due to more strict dependency checks (this\r\ntarget is currently used via transitive dependencies).","shortMessageHtmlLink":"Adds import that was used via a transitive dependency. (#6856)"}},{"before":"5c8b643f375280df93d9a75390b99ebaea8cf4b9","after":"7df7ad9855f0f7b4bd8ac90350580bc482c9d062","ref":"refs/heads/master","pushedAt":"2024-05-20T00:34:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AnuarTB","name":"Anuar Talipov","path":"/AnuarTB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5575949?s=80&v=4"},"commit":{"message":"Group colours by regex of the experiment name (UI). (#6847)\n\n**NOTE**: This PR is a continuation of #6846.\r\n\r\n## Motivation for features / changes\r\n\r\nUsers want to color runs by the regex string of the corresponding to\r\nruns experiment names.\r\n\r\n## Technical description of changes\r\n\r\n- Added new GroupBy type, REGEX_BY_EXP.\r\n- Added a dropdown in dialog window, so users could select between regex\r\nfor run name or experiment name.\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\nN/A since internal change. \r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\n\r\n- Run tensorboard.corp server.\r\n- Click on color grouping icon and select `Regex`.\r\n- Select `Experiment Name` in dropdown.\r\n\r\n## Alternate designs / implementations considered (or N/A)\r\nN/A","shortMessageHtmlLink":"Group colours by regex of the experiment name (UI). (#6847)"}},{"before":"d5a27132d450b84f805142e5e35845ff6b67825c","after":"5c8b643f375280df93d9a75390b99ebaea8cf4b9","ref":"refs/heads/master","pushedAt":"2024-05-17T12:04:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AnuarTB","name":"Anuar Talipov","path":"/AnuarTB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5575949?s=80&v=4"},"commit":{"message":"Pin nightly since keras_util test has failed. (#6854)\n\nTemporary fix since master is failing due to upstream changes in Keras. \r\n\r\n\r\n[Link](https://github.com/tensorflow/tensorboard/actions/runs/9111112046)\r\nto first failure.","shortMessageHtmlLink":"Pin nightly since keras_util test has failed. (#6854)"}},{"before":"aa5427294c99d95b6e0bdf47fd79e4aa23db79bc","after":"d5a27132d450b84f805142e5e35845ff6b67825c","ref":"refs/heads/master","pushedAt":"2024-05-13T02:15:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global pins] enable globalpins by default (#6850)\n\n## Motivation for features / changes\r\nlaunch global pins feature by enabling the feature by default \r\n## Technical description of changes\r\n\r\n## Screenshots of UI changes (or N/A)\r\n### Light mode\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/c5163d74-a5ef-4ba0-969b-4a87111d55c7)\r\n\r\n### Dark mode\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/d568f957-9d55-4b93-bb65-7bca50e6c39f)\r\n#### pop up\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/9ce2939c-390f-4d2a-b464-a92ab7c4a52b)\r\n\r\n### Corp theme\r\n\"image\"\r\nsrc=\"https://github.com/tensorflow/tensorboard/assets/24772412/231a68f1-4ab0-4c6e-ab82-15ec1f17181c\"\r\n\r\n\r\nhttps://screenshot.googleplex.com/7WaVHXBFfAfHYUk\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\n* Needs to update scuba test images after this PR is merged\r\n\r\n## Alternate designs / implementations considered (or N/A)","shortMessageHtmlLink":"[Global pins] enable globalpins by default (#6850)"}},{"before":"29850f60307925a15c369fecdb694a05baf77390","after":"aa5427294c99d95b6e0bdf47fd79e4aa23db79bc","ref":"refs/heads/master","pushedAt":"2024-05-08T13:45:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AnuarTB","name":"Anuar Talipov","path":"/AnuarTB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5575949?s=80&v=4"},"commit":{"message":"Group colours by regex of the experiment name. (#6846)\n\n## Motivation for features / changes\r\n\r\nUsers want to color runs by the regex string of the corresponding to\r\nruns experiment names.\r\n\r\n## Technical description of changes\r\n\r\n- Added new GroupBy type, REGEX_BY_EXP.\r\n- Added a dropdown in dialog window, so users could select between regex\r\nfor run name or experiment name.\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\nN/A since internal change. \r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\n\r\n- Run tensorboard.corp server.\r\n- Click on color grouping icon and select `Regex`.\r\n- Select `Experiment Name` in dropdown.\r\n\r\n## Alternate designs / implementations considered (or N/A)\r\nN/A","shortMessageHtmlLink":"Group colours by regex of the experiment name. (#6846)"}},{"before":"d4c5c825a5677bf1d22d1d9290bb439f0ce7e861","after":"29850f60307925a15c369fecdb694a05baf77390","ref":"refs/heads/master","pushedAt":"2024-05-08T11:44:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global Pins] Saves all currently pinned cards if the user has enabled global pins. (#6848)\n\n## Motivation for features / changes\r\n\r\nFeature request during the teamfood: `Clicking disable pins -> pinning a\r\ncard -> clicking enable pins` doesn't save the currently pinned card. It\r\nseems reasonable to save all currently pinned cards when the setting is\r\nactivated.\r\n\r\nThis PR saves all currently pinned cards when user clicks enable global\r\npins.\r\n\r\n## Technical description of changes\r\n\r\n* 97c6324389e1a9a5f51b89e5e33b0665ead533a4 Added `saveScalarPins` to the\r\ndata source\r\n\r\n* c6be93b Modified `addOrRemovePinsOnToggle` logic to include adding\r\npins logic\r\n* Previously, if a user disabled the global pin feature, all pins would\r\nbe removed.\r\n* This PR added logic that will cause all currently pinned cards to be\r\nsaved to local storage when the user activates the feature.\r\n\r\n## Screenshots of UI changes (or N/A)\r\nN/A\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\nUnit test passes\r\n## Alternate designs / implementations considered (or N/A)\r\nN/A","shortMessageHtmlLink":"[Global Pins] Saves all currently pinned cards if the user has enable…"}},{"before":"af346056e1c158b6ed6a38b136af648b2e12a986","after":"d4c5c825a5677bf1d22d1d9290bb439f0ce7e861","ref":"refs/heads/master","pushedAt":"2024-05-02T13:41:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global Pins] [Quick Fix] Apply theme color to the check box (#6845)\n\n## Motivation for features / changes\r\nTheme color was not applied to the checkbox. \r\n## Technical description of changes\r\nApply `color=\"primary\"` to the `saving_pins_checkbox_component`\r\n\r\n## Screenshots of UI changes (or N/A)\r\nAS-IS\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/12ed994a-a3b4-4137-b7b8-7a22b4a9af37)\r\n\r\n\r\nTO-BE\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/2aa3fbd7-b46e-46fd-b365-debc72cf2883)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\ntested with ` tb_theme=corp` & TAP presubmit passes\r\n\r\n\r\n## Alternate designs / implementations considered (or N/A)","shortMessageHtmlLink":"[Global Pins] [Quick Fix] Apply theme color to the check box (#6845)"}},{"before":"ad1da0c01f29cc96fe39677b6104110e9a55decd","after":"af346056e1c158b6ed6a38b136af648b2e12a986","ref":"refs/heads/master","pushedAt":"2024-04-30T06:26:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global Pins] Shows a confirmation dialog when disabling the global pin feature (#6843)\n\n## Motivation for features / changes\r\nRegarding #6831 , this PR adds confirmation dialog\" that appears when\r\nthe user clears the checkbox to make the user aware that local storage\r\nis disappearing.\r\n\r\n## Technical description of changes\r\n0e63b07 created a `saving pins dialog` component\r\n\r\n05e06f5 Created a `saving pins checkbox` component\r\n* The Save Pin checkbox prevents the default click and must be done\r\nafter confirmation in the modal. So I added\r\n`MAT_CHECKBOX_DEFAULT_OPTIONS`\r\n(https://v15.material.angular.io/comComponents/checkbox/overview#click-action-config)\r\nto prevent the default click event. However, if I add this directly to\r\nthe `settings view component`, all checkboxes will be disabled,\r\nincluding other unwanted ones. So, I created a separate checkbox for the\r\nSave Pin checkbox. Please let me know is there any other good way to do\r\nthis.\r\n\r\n6ba778e Make the dialog shows up when user clears the checkbox\r\n* Passes to `onEnableSavingPinsToggled` whether the checkbox is\r\nselected.\r\n* If the checkbox is selected and user clicks it, it means that the user\r\ndisables the global pin, so a dialog box is displayed.\r\n* If the checkbox is not checked but is clicked, it means the user is\r\ntrying to enable a global pin and no dialog box will be displayed.\r\n* `onEnableSavingPinsToggled` and `isSavingPinsEnabled` is passed to\r\n`saving-pins-checkbox` component.\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/eb442565-4f39-45e7-b893-4866ee3fc1e4)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\nunit test passes + TAP presubmit passes \r\n## Alternate designs / implementations considered (or N/A)","shortMessageHtmlLink":"[Global Pins] Shows a confirmation dialog when disabling the global p…"}},{"before":"0c8596b5ad3c487e3a4729cac3571b4b542792b5","after":null,"ref":"refs/heads/add_column_final","pushedAt":"2024-04-29T09:09:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"}},{"before":"e9d000985c93e46852ba610bb0afbaeab5d4c4d1","after":"ad1da0c01f29cc96fe39677b6104110e9a55decd","ref":"refs/heads/master","pushedAt":"2024-04-29T09:09:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Makes data table add column sticky (#6839)\n\n## Motivation for features / changes\r\nThe add column button in the runs table will be hidden when the table is\r\nwide, which will often be the case. This makes the \"add\" feature very\r\ndifficult to discover.\r\n\r\ncontext: b/332788091\r\n\r\n## Technical description of changes\r\n- Moves the add button column outside of and adjacent to the data table\r\n(previously it was a column of the table) and makes it sticky\r\n- Adds additional configuration options to data table to allow runs and\r\nscalar tables to have slightly different designs\r\n\r\n## Screenshots of UI changes (or N/A)\r\nNotice the add column is fixed to the right:\r\n\r\n![sticky](https://github.com/tensorflow/tensorboard/assets/736199/0f7aca5c-0903-438a-bafd-ddc033e262f7)\r\n\r\nScalar table add column is slightly narrower:\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/736199/e8c37505-4c3f-41bd-98f3-3b31f99e206e)\r\n\r\n## Alternate designs / implementations considered (or N/A)\r\n- Tried adding the add columns to the consumer components of the data\r\ntable (runs data table and scalar card data table) instead. But this led\r\nto too much code duplication in the components and templates.\r\n- Tried making the add column a regular table column, instead of adding\r\nit outside in a separate div. But making the column sticky requires\r\nstyling the table rows, which data table doesn't provide access to (rows\r\nare configured solely in the consumer components). Also, the chosen\r\nimplementation is arguably more consistent with the current design as\r\nthe add \"column\" doesn't actually function as a table column at all","shortMessageHtmlLink":"Makes data table add column sticky (#6839)"}},{"before":"24d62c4df7207ea767db23564d457c08344224f6","after":"0c8596b5ad3c487e3a4729cac3571b4b542792b5","ref":"refs/heads/add_column_final","pushedAt":"2024-04-29T06:31:58.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Merge branch 'master' into add_column_final","shortMessageHtmlLink":"Merge branch 'master' into add_column_final"}},{"before":"781e9800c0151c8ae30d1408af820bd5846257c5","after":null,"ref":"refs/heads/fix_scroll_final","pushedAt":"2024-04-29T06:25:48.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"}},{"before":"4023658707d54976622c3b3a32f5a4a215689da7","after":"e9d000985c93e46852ba610bb0afbaeab5d4c4d1","ref":"refs/heads/master","pushedAt":"2024-04-29T06:25:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"[Runs table] Moves expand button to layout container and fixes sidebar scroll (#6837)\n\n## Motivation for features / changes\r\n- Moving the expand button out of the runs table is required to make it\r\ncompatible with the upcoming sticky add column b/332788091\r\n- When the table is both vertically long and horizontally wide, it's\r\nvery difficult to scroll horizontally: users must scroll all the way to\r\nthe bottom of the table in order to access the horizontal scroll bar.\r\nb/332720882\r\n\r\n## Technical description of changes\r\n- Moves the \"expand button\" from inside the runs data table to the\r\nLayoutContainer (in the side bar).\r\n- Moves the \"overflow\" css property from the runs table to\r\nRunsSelectorComponent (the runs table wrapper)\r\n- Makes the runs table header sticky. This was already set, but wasn't\r\nbeing applied due to a missing \"position: relative\" parent.\r\n\r\n## Screenshots of UI changes (or N/A)\r\nsticky header:\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/736199/f2569648-6395-4411-9302-f626b6bd5e9f)\r\n\r\nexpand table button:\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/736199/35b2e624-f015-41dc-9114-0cab63b70eef)","shortMessageHtmlLink":"[Runs table] Moves expand button to layout container and fixes sideba…"}},{"before":"9f51a3008ad1506b5a9ec43d354408d5f75df2ed","after":"4023658707d54976622c3b3a32f5a4a215689da7","ref":"refs/heads/master","pushedAt":"2024-04-24T22:48:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global pins] Correct the incorrect name change and add test cases (#6840)\n\n## Motivation for features / changes\r\n\r\nThis PR fixes the renaming in #6831 and adds test cases to make the test\r\nrobust.\r\n\r\n## Technical description of changes\r\n\r\n* Tried to rename `disableSavingPins` to `removeSavedPinsOnDisable`, but\r\n#6831 accidentally changed `removeAllPins` to\r\n`removeSavedPinsOnDisable`.\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\n* Added test cases + cl TAP presubmit passes\r\n## Alternate designs / implementations considered (or N/A)","shortMessageHtmlLink":"[Global pins] Correct the incorrect name change and add test cases (#…"}},{"before":"e11681dd158fe0e35bc7a25dea5d44d389dd69d5","after":"781e9800c0151c8ae30d1408af820bd5846257c5","ref":"refs/heads/fix_scroll_final","pushedAt":"2024-04-24T14:30:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Remove unused css variable","shortMessageHtmlLink":"Remove unused css variable"}},{"before":"b38870237b7f4a55a7f43a83178c03218cb4595c","after":"24d62c4df7207ea767db23564d457c08344224f6","ref":"refs/heads/add_column_final","pushedAt":"2024-04-24T14:26:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Addresses review comments","shortMessageHtmlLink":"Addresses review comments"}},{"before":"98f026029ba4e301140b72aa968578be5a036742","after":null,"ref":"refs/heads/memoize_column_fn","pushedAt":"2024-04-24T11:19:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEa6kAUAA","startCursor":null,"endCursor":null}},"title":"Activity · tensorflow/tensorboard"}