Remove the cleaning of the cache to speed up the build. #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpmorgan
approved these changes
Apr 16, 2020
|
@gabrieldemarmiesse I still see in https://github.com/tensorflow/addons/runs/591598847 21m 20s. Is this just a local effect? |
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1655
We cleaned the cache to make sure that the options for building the wheels were taken into account, but one could argue that it's bazel's job to invalidate the cache, not ours, so we can let bazel decide what to do.
When building the wheel, we went from 5m to 1s.