Moved run_all_in_graph_and_eager_mode in basic decoder #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
About the use of gpu for testing going forward, unless we're testing some code with a custom op, we need a strong reason to run in both cpu and gpu mode. |
Co-Authored-By: Gabriel de Marmiesse <[email protected]>
Co-Authored-By: Gabriel de Marmiesse <[email protected]>
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Moved run_all_in_graph_and_eager_mode in basic decoder * minor removal * Update tensorflow_addons/seq2seq/tests/basic_decoder_test.py Co-Authored-By: Gabriel de Marmiesse <[email protected]> * Update tensorflow_addons/seq2seq/tests/basic_decoder_test.py Co-Authored-By: Gabriel de Marmiesse <[email protected]> Co-authored-by: Gabriel de Marmiesse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @gabrieldemarmiesse. Dividing into several parts since it's large, and not sure if removing
use_gpuis a good idea. The reason is using gpu seems not helping a lot in LSTM, only if it's self-attention(transformer) based. May need your suggestions.