Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved tests out of run_in_graph_and_eager_mode in lazy adam #1599

Merged
merged 5 commits into from
Apr 17, 2020
Merged

Moved tests out of run_in_graph_and_eager_mode in lazy adam #1599

merged 5 commits into from
Apr 17, 2020

Conversation

autoih
Copy link
Member

@autoih autoih commented Apr 6, 2020

@bot-of-gabrieldemarmiesse
Copy link

@SSaishruthi

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added cla: no and removed cla: yes labels Apr 7, 2020
@gabrieldemarmiesse
Copy link
Member

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 7, 2020
gabrieldemarmiesse
gabrieldemarmiesse reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This run_deprecated_v1 is very tricky to remove...

tensorflow_addons/optimizers/tests/lazy_adam_test.py Outdated
np.allclose(np.asanyarray([3.0, 4.0]), var1.numpy())

# Run 3 steps of intertwined Adam1 and Adam2.
for t in range(3):
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse Apr 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this loops, the TF tensors are never updated. Before there was a run() per iteration. That's very strange. @SSaishruthi we're trying to remove the @test_utils.run_deprecated_v1 and run the test in eager mode, could you help us on this one?

@gabrieldemarmiesse gabrieldemarmiesse self-assigned this Apr 15, 2020
gabrieldemarmiesse
gabrieldemarmiesse approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other function is tricky to change. I'll try to do it. In the meantime, we can merge the last test.

@gabrieldemarmiesse gabrieldemarmiesse merged commit dc2bdfb into tensorflow:master Apr 17, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@autoih @gabrieldemarmiesse
Moved tests out of run_in_graph_and_eager_mode in lazy adam (tensorfl…
35639c6 
…ow#1599)

* Moved tests out of run_in_graph_and_eager_mode in lazy adam

* Update tensorflow_addons/optimizers/lazy_adam_test.py

* Keep the eager function.

Co-authored-by: Gabriel de Marmiesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

@facaiy facaiy Awaiting requested review from facaiy

@Squadrick Squadrick Awaiting requested review from Squadrick

@WindQAQ WindQAQ Awaiting requested review from WindQAQ

Assignees

@gabrieldemarmiesse gabrieldemarmiesse

Labels
awaiting testing (then merge) cla: yes optimizers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autoih @bot-of-gabrieldemarmiesse @googlebot @gabrieldemarmiesse