Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Publish Docker image #316

Open
cretz opened this issue Aug 24, 2023 · 7 comments
Open

[Feature Request] Publish Docker image #316

cretz opened this issue Aug 24, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Aug 24, 2023

Describe the solution you'd like

Need a docker image for this single binary

@cretz cretz added the enhancement New feature or request label Aug 24, 2023
@slamdev
Copy link

slamdev commented Nov 23, 2023

while waiting for the official image you can use this one: https://github.com/slamdev/temporalite-container-image

version: "3.8"
services:
  temporal:
    # https://hub.docker.com/r/slamdev/temporalite/tags
    image: slamdev/temporalite:0.10.7
    restart: on-failure
    command:
      - --namespace=default
      - --db-filename=/tmp/db
    tmpfs:
      - /tmp
    ports:
      - "7233:7233"
      - "8233:8233"

ignore temporalite name, its temporal cli under the hood, I just re-purposed the repo that was used to build deprecated temporalite.

@ElanHasson
Copy link

ElanHasson commented Feb 20, 2024

@cretz Can i just send a PR for this?

I was thinking:

Add a GHA workflow to build, test, sign the image and push to ghcr on every release?

Edit: Is https://github.com/temporalio/cli/pull/463/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557 this?

#463

@cretz
Copy link
Member Author

cretz commented Feb 20, 2024

We are actually in the process of rewriting the innards of the CLI of which #463 is part, yes. We just don't have the publish step yet or the rest of the rewrite completed, stay tuned.

@ElanHasson
Copy link

Love it thanks!

@ElanHasson
Copy link

so, temporalio/admin-tools has the cli as well :)

@enricoschaaf
Copy link

Do I see this right that the is no replacement yet for https://github.com/slamdev/temporalite-container-image? Since the PR is merged I assumed it maybe there is but it seems the action just triggers docker builds of other containers that contain the cli but no standalone image.

@slamdev
Copy link

slamdev commented Jun 27, 2024

Do I see this right that the is no replacement yet for https://github.com/slamdev/temporalite-container-image? Since the PR is merged I assumed it maybe there is but it seems the action just triggers docker builds of other containers that contain the cli but no standalone image.

you can switch to official image now, that's how I use it:

  temporal:
    # https://hub.docker.com/r/temporalio/server/tags
    image: temporalio/server:1.21.5.0
    restart: on-failure
    user: "0:0" # running as root to avoid permission issues with writing to /tmp/sqlite/db
    entrypoint:
      - temporal
      - server
      - start-dev
      - --namespace=default
      - --db-filename=/tmp/sqlite/db
      - --ip=0.0.0.0
    tmpfs:
      - /tmp/sqlite
    ports:
      - "7233:7233"
      - "8233:8233"

PS: I archived my repo to remove the confusion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants