init #19
Open
init #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no signal set up when the pipeline was shutting down. Now it will stop either if it receives an EOF or if the pipeline is shutting down.
Initial work for the json flag which incidentaly made me realize I could remove the `--data` flag. It is replaced by adding the `--data-timeout` flag that will be triggered if no data is received from the pipeline. Usually, unless it is to mirror data, the pipeline will already be filled with data when reaching the module. But HTTP does not work with mirroring data, because the server has to fully read the request in order to send the response. This why we have websockets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.