Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload the profile after passkey creation #1172

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

bjoern-m
Copy link
Contributor

@bjoern-m bjoern-m commented Nov 7, 2023

Description

The passkey list in the profile remained empty after account creation (incl. passkey onboarding), when embedding hanko-auth and hanko-profile on the same page.

Implementation

  • Changed the profile to initialize when the "onAuthFlowCompleted" has been received (instead of "onSessionCreated").

Additional context

fixes #1138

@bjoern-m bjoern-m marked this pull request as ready for review November 7, 2023 11:29
@bjoern-m bjoern-m changed the title fix(elements): reload the profile after passkey creation fix: reload the profile after passkey creation Nov 7, 2023
@bjoern-m bjoern-m merged commit bce1247 into main Nov 7, 2023
12 checks passed
@bjoern-m bjoern-m deleted the fix-init-profile-after-onboarding branch November 7, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Passkey created during onboarding doesn't show up in profile
2 participants