Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to escape the regEx characters on line 239 #10

Open
up209d opened this issue Jan 5, 2018 · 2 comments
Open

Need to escape the regEx characters on line 239 #10

up209d opened this issue Jan 5, 2018 · 2 comments

Comments

@up209d
Copy link

up209d commented Jan 5, 2018

Line 239
str = str.replace(new RegExp('"' + sKey + '"', 'g'), '"' + oKeys[sKey] + '"');

I think you might forget to escape the regEx characters here it should be:

str = str.replace(new RegExp(escapeRegExp('"' + sKey + '"'), 'g'), '"' + oKeys[sKey] + '"');

If not, when trying to decompress, this case /"("/ will corrupt the process. Resulted with error Uncaught SyntaxError: Invalid regular expression: /"("/: Unterminated group

@up209d
Copy link
Author

up209d commented Apr 23, 2018

It looks like the author abandoned his project. (_ _!)

@tcorral
Copy link
Owner

tcorral commented Apr 26, 2018

Hi, @up209d
The project is not abandoned but I don't have time to handle every single project.

Could you provide a test to check this error, please?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants